Fully install the package before revdep checking#1397
Closed
yihui wants to merge 1 commit intor-lib:masterfrom
yihui:patch-1
Closed
Fully install the package before revdep checking#1397yihui wants to merge 1 commit intor-lib:masterfrom yihui:patch-1
yihui wants to merge 1 commit intor-lib:masterfrom
yihui:patch-1
Conversation
During revdep checking, I found some packages actually had tests that depended on `system.file('docs', package)`. If the package is not fully installed, these tests will fail.
Member
|
Thanks - this should be resolved in revdepcheck (which does a much better job installation generally) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During revdep checking, I found some packages actually had tests that depended on
system.file('docs', package). If the package is not fully installed, these tests will fail.