This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Repository navigation
Use -stdlib=libc++ on fedora-clang-devel - #60
Merged
Merged
Conversation
Contributor
|
But they also rebuild system dependencies to link against libc++ and we don't. Wouldn't that cause problems? Can a program link to both libc++ and libstdc++? |
Contributor
Author
|
I think they rebuild some of them to do that, but some they don't? The list of rebuilt packages from that link is: The details are well over my head here! In Arrow's case we need this in our CI to keep from CRAN check surprises, but we're certainly not offended if our CI is where it needs to stay. |
Contributor
|
OK, let's try it then. |
Contributor
|
Thanks! |
paleolimbot
added a commit
to apache/arrow
that referenced
this pull request
Aug 24, 2022
#12824) In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
zagto
pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
apache#12824) In ARROW-15857 (apache#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (rstudio/sass#104 and r-hub/rhub-linux-builders#60). These upstreams are now both released, so we can remove the kludge from modification of the docker image. Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly modified version of #52 that uses a slightly different way to update the Makevars (in this case, CXX and family). The gist of it is that the fedora-clang-devel check is using a custom build of clang that can be replicated using
-stdlib=libc++(this is the suggested method according to https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang ). I copied the Makevars addition from the debian-gcc10-devel image, which also updates the Makevars. I checked this using:docker build . --tag fedora-clang-devel docker run --rm -it fedora-clang-devel /opt/R-devel/bin/R CMD config CXX docker run --rm -it fedora-clang-devel /opt/R-devel/bin/R CMD config CXX11 docker run --rm -it fedora-clang-devel /opt/R-devel/bin/R CMD config CXX14 docker run --rm -it fedora-clang-devel /opt/R-devel/bin/R CMD config CXX17 docker run --rm -it fedora-clang-devel /opt/R-devel/bin/R CMD config CXX20We also ran into a problem installing the 'sass' package which we fixed by adding
-stdlib=libc++to the LDFLAGS, but I think the root cause of that is that 'sass' isn't using CXX to do the linking (rstudio/sass#104, apache/arrow#12734).