fix settings stringdata pointer#80
Merged
Merged
Conversation
stringdata pointer was pointing to the wrong location, it should point to the start of the string buffer before any strings are written, not the middle mod string offsets need to be calculated relative to the start of all strings, not relative to where mod strings begin tested and can confirm it works as intended now
Collaborator
|
Thanks! looks good, though rename the |
Mauler125
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringdata pointer was pointing to the wrong location, it should point to the start of the string buffer before any strings are written, not the middle mod string offsets need to be calculated relative to the start of all strings, not relative to where mod strings begin tested and can confirm it works as intended now