Minor fixes#67
Merged
Merged
Conversation
Model and settings dependencies need to be explicitly defined; a pointer needs to be set to the start of the model dependencies GUID, along with its count. Settings assets have the exact same process. The runtime uses this to precache models and all other assets inside the settings assets when an animation is getting loaded and played. This patch allows common.rpak to be fully rebuilt while maintaining original quality and behavior.
Should return const char*.
Check error field first before checking if the pointer points to the end.
Use a 64bit type for consistency throughout the code base.
Check for duplicate GUID's (collisions or user errors) already takes place within BeginAsset(), doing it in AddJSONAsset() is extraneous, and also will not guarantee full coverage as the auto-add feature bypasses this check all together. The check in BeginAsset() guarantees full coverage. Also did some improvements to the existing error to report whether we have a collision or when the user has made a mistake.
IJARika
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.