UI image atlas improvements#65
Merged
Merged
Conversation
Match actual asset name just like all the other source files.
Reimplement it.
Must be of type string!
This was not implemented until now, image paths will now be stored inside the RPak for debugging if keepDevOnly is set.
The f0 and f1 member variables are used for inwards cropping from left and top.
- Make sure we never have more than UINT16_MAX images. - Make sure that the image path is never empty. - Added extra details regarding automatic calculation for image scales and offsets. - Improved error messages.
IJARika
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathfield was never checked for its type (needs to be string).