OhmicEnvironment without mpmath#2859
Merged
Merged
Conversation
added 2 commits
April 6, 2026 13:36
Member
|
Just a note that zeta function with complex argument is also under development in scipy, see scipy/scipy#14073 However, it will take a while until we can use that, so I think this would be a good addition that allows us to remove mpmath dependency now. |
Member
Author
Presently it's only for riemann zeta (q=0). Support for what we need seems far away. |
hodgestar
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mpmathis only needed for one functionzetathat is not available for complex number in scipy. An efficient equation to implement it is available on wikipedia.This implementation is not as robust as mpmath's when s is smaller than 1, but works well in the range needed for OhmicEnvironment.