Allow all function to work with auto_real_casting=False#2752
Merged
Conversation
Ericgig
force-pushed
the
bug_expect_casting
branch
from
4188203 to
ca89b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have the options
auto_real_castingthat control the casting to real in expect for hermitian operators.It's is useful for plug-in with auto-differentiation, but it was not fully tested and broke some functionalities.
I ran the full test without auto casting and fixed the issues:
expectwith multiple state would fails when trying to return an array.run_from_experiment."propagator"method convergence would break.