Add support for FermionicEnvironment in Bloch RedFieldTensor.#2628
Merged
Conversation
added 7 commits
February 7, 2025 09:41
Ericgig
force-pushed
the
feature.brcrossterm
branch
from
5e2e9bd to
8e09fe5
Compare
Ericgig
force-pushed
the
feature.brcrossterm
branch
from
8e09fe5 to
4ca6a22
Compare
pmenczel
reviewed
Feb 13, 2025
Member
There was a problem hiding this comment.
Only a few comments:
- The docstrings in
qutip.core.blochredfielddon't mention where environment objects are accepted. - Actually, the functions in
qutip.core.blochredfieldare not in the API documentation. Is that intentional? - You write "An example of fermion environment in the guide could be good." Additionally, it would be good to update the bosonic examples there to show how BosonicEnvironment objects can be used.
I am not sure whether these points are within the scope of this PR. Other than this, looks great to me, but waiting for @nwlambert tests before approving
Edit: by the way, this would complete points 1 and 2 of issue #2580
Comment on lines
+20
to
+23
| SpectrumType = Union[ | ||
| Coefficient, str, CoeffProtocol, | ||
| BosonicEnvironment, FermionicEnvironment | ||
| ] |
Member
There was a problem hiding this comment.
Should this be added to the autodoc_type_aliases in doc/conf.py?
Member
Author
There was a problem hiding this comment.
I added the function to the apidoc and added environment in the spectra docstring.
Not sure about having this as an alias.
It's its only use. ( the spectra in floquet is not the same.)
Ericgig
force-pushed
the
feature.brcrossterm
branch
from
6b3c7bd to
edc7e6c
Compare
Ericgig
force-pushed
the
feature.brcrossterm
branch
from
edc7e6c to
e817f38
Compare
nwlambert
approved these changes
Feb 14, 2025
nwlambert
left a comment
nwlambert
left a comment
Member
There was a problem hiding this comment.
works great on all examples I tried, thanks eric!
pmenczel
approved these changes
Feb 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FermionicEnvironmentin Blochbrmesolve,BRSolverandbloch_redfield_tensor.brcrossterm, compute cross term in equation (6) of our guide.br_dtypeparameter inbloch_redfield_tensor.An example of fermion environment in the guide could be good.