Removed certain distributions already in visualization#2607
Merged
Ericgig merged 20 commits intoJan 14, 2025
Conversation
Ericgig
reviewed
Jan 13, 2025
Ericgig
left a comment
Ericgig
left a comment
Member
There was a problem hiding this comment.
Looking good for the removals.
plot_qfunc looks good, but it need to be integrated in the rest of the code more: apidoc, __all__, tests, animations, towncrier... You can search for plot_wigner in the full project, for a list places.
Ericgig
reviewed
Jan 13, 2025
Co-authored-by: Eric Giguère <[email protected]>
Ericgig
reviewed
Jan 14, 2025
Ericgig
left a comment
Ericgig
left a comment
Member
There was a problem hiding this comment.
Could you add anim_qfunc in the apidoc.
Also move the distribution section as an automodule under "Graphs and Visualization".
Ericgig
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed WignerDistribution, QDistribution from distributions.py and their tests.
Added Harmonic Oscillator to API doc.