Add support for numpy 2 #2421
Merged
Add support for numpy 2 #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 8, 2024 11:55
hodgestar
reviewed
May 10, 2024
Contributor
hodgestar
left a comment
hodgestar
left a comment
There was a problem hiding this comment.
Woot for starting to get things ready for numpy 2. Did a quick review of the changes so far. Most look good.
Ericgig
commented
May 13, 2024
Contributor
|
Numpy is maintaining a list of project versions that support numpy 2 -- numpy/numpy#26191. They're waiting of downstream packages to be ready before release. We could add ourselves there if we liked. |
eendebakpt
reviewed
May 30, 2024
Contributor
There was a problem hiding this comment.
Numpy 2.0 is scheduled to be released June 16th (see numpy/numpy#24300 (comment))
Co-authored-by: Pieter Eendebak <[email protected]>
hodgestar
approved these changes
Jun 4, 2024
Ericgig
added a commit
to Ericgig/qutip
that referenced
this pull request
Jun 20, 2024
Add support for numpy 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the up comming numpy v2:
I did not update the requirement yet, it must be installed in
--no-build-isolation.When it's officially released, we will need to update
pyproject.tomlandsetup.cfg, and possibly add test for np2 on windows and mac.Here are the changes that affect us:
np.array(.., copy=False)no longer mean copy only if needed.copy=Nonewas added for that.np.trapzwas replaced bynp.trapezoid. Since there are no overlaps, I opted to usescipy.integrate.trapezoidinstead.np.array(1, np.int32) * 2**33will enforce the integer type and overflow.Py_intptr_tfrompython.his no longer available through numpy cython interface.