fix: further reduces memory usage #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow did not report another problem in the previous test, but discovered and further fixed it during QA.
Further prevents potential problems when the number of scripts is large, although unlikely to be of the same order of magnitude.
The memory peak of the test script was up to about ~25MB in the real-device test, due to dynamic compilation of
@matchpatterns.This problem will be further solved in version 5.0 due to the rewriting of related functions.
But currently it is unlikely that the limit will be exceeded again unless multiple large scripts are installed, which is effective as a mitigation measure.