fix: add light theme color for console log #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for light and dark theme colors in console logs by introducing a helper and updating existing log statements.
- Introduce
getColorutility to abstract theme-aware CSS colors. - Replace hardcoded color strings in console logs with calls to
getColor. - Import the new utility in the userscripts entry point.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/shared/colors.js | New getColor function providing theme-based CSS color strings. |
| src/ext/content-scripts/entry-userscripts.js | Updated console log calls to use getColor instead of literals. |
Comments suppressed due to low confidence (2)
src/shared/colors.js:1
- The JSDoc for
getColoris missing a@returns {string}annotation; adding it will improve IDE support and clarity.
/**
src/ext/content-scripts/entry-userscripts.js:66
- These new
getColor-based console statements should be covered by existing or new unit tests to verify correct CSS strings under both light and dark schemes.
console.info(`Injecting: ${name} %c(js/${world})`, getColor("yellow"));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: