Merged
Conversation
Co-authored-by: AntsyLich <[email protected]>
(cherry picked from commit 3e6afee13b9fd5716f7f2d547b3edcd3e17915db)
Co-authored-by: AntsyLich <[email protected]>
Co-authored-by: AntsyLich <[email protected]>
Closes #2510 Co-authored-by: Cuong-Tran <[email protected]> (cherry picked from commit 906d6f3cdbd6f7168d9cdea0c3eb8f9c663a09c2)
(cherry picked from commit 47fe792ddc5a342ecc4685d57143cfb40f0682f7)
(cherry picked from commit 89c4e3bb39b7450a9aedcf9d720c74c04cd560ff)
Previously, the app made one request for the search, and then fired off 1 request per search result to obtain additional data, such as each title's synopsis, etc. However, MAL's search allows field selection during the initial query, which will return all the data in that first response, avoiding the massive bunch of requests (and alleviating some pressure on MAL from our userbase). By combining the selected fields into one constant, I was able to also get rid of the MALUserListSearch entirely because it was redundant. This allows for a unified MALManga->TrackSearch helper, further reducing complexity. I got to my "11x" improvement because on page of search results has 10 elements, and this change turns 11 (1+10 for results) requests into 1. Co-authored-by: MajorTanya <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ceb/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/it/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/pt_BR/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/bn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ceb/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/it/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ko/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pt_BR/ Translation: Mihon/Mihon Translation: Mihon/Mihon Plurals Co-authored-by: Ahmed TOUCHANE <[email protected]> Co-authored-by: Anderhale <[email protected]> Co-authored-by: Eduard Ereza Martínez <[email protected]> Co-authored-by: Eugene <[email protected]> Co-authored-by: Gino Cicatiello <[email protected]> Co-authored-by: Hiroshi <[email protected]> Co-authored-by: Luis Antonio <[email protected]> Co-authored-by: NormalRandomPeople <[email protected]> (cherry picked from commit e6f72000ba62302c3e4817a5f17057e5a8d7eafc)
Co-authored-by: MajorTanya <[email protected]>
…t running (#2837) (cherry picked from commit 4ce249c1a0ee9f3a20d91214fd09145e0924b2e4)
…rbose logging (#2836) (cherry picked from commit a4f5a8184c956a3d92183e52a1c96d786cfe9517)
(cherry picked from commit cf13012629571e2097796b50df238f69e62843b3)
…(#2849) (cherry picked from commit 99e6fa3c06e1dc24255a73aa5741a72c82d94d91)
(cherry picked from commit e659e90c26814c9a29bf668545b4f10294f3c6b9)
(cherry picked from commit 13975d6f7eea21b3ba4be31736038ef2f855bfea)
* Add Filters to Updates screen Behaves basically like the filters in the library: - Unread: Show/Don't show unread chapters - Downloaded: Show/Don't show downloaded chapters - Started: Show/Don't show chapters that have some progress but aren't fully Read - Bookmarked: Show/Don't show chapters that have been bookmarked Started behaves differently from its Library counterpart because the actual manga data is not available at this point in time and I thought calling getManga for each entry without caching would be a pretty bad idea. I have modelled this closely on the filter control flow in the Library, but I'm sure this can be simplified/adjusted in some way. * Move most filtering logic to SQL Unread, Started, and Bookmarked filters are now part of the SQL query. Download state cannot be filtered in the database so it remains in Kotlin. Because the Downloaded filter has to be run in Kotlin, the combine flow uses the preferences flow twice, once to get the SQL query params and once for the Kotlin filters (only Downloaded at this time). * Add "Hide excluded scanlators" to update filters Based on the work done in aniyomiorg#1623 but integrated with the other filters in this PR. Added the user as a co-author for credit. Co-authored-by: Dani <[email protected]> Co-authored-by: MajorTanya <[email protected]>
(cherry picked from commit 49c4d08b22b6a440b93b58bd78280807550d6198)
I'm tired of people thinking the current wording is an error. Improved wordings welcome, this was just my first decent guess. (cherry picked from commit 05d90ea4d652cd7ead385ec954e0ae2dc332a012)
(cherry picked from commit fa966fcb977c2aabd9930c10c6bb99305e22ee37)
(cherry picked from commit 2037ec45006b54da0e64b3e07bae4c87e261ee59)
(cherry picked from commit ede2f56bc6531f69553d0f95cf422b7f6d15b90b)
…2.0 (#2892) (cherry picked from commit e6c67003511b601d49bc175b83596568ddfe09d9)
(cherry picked from commit d6e17b04c39c9d800c57d75e29714a51fbf902f8)
Co-authored-by: Cuong-Tran <[email protected]>
(cherry picked from commit 82ffc8efa69cb86229fe8b677f12942c80b88a15)
(cherry picked from commit c0a1203541931a9090e6769acdb596c9ea4a011b)
…2.1 (#2909) (cherry picked from commit 31a9ff261e5e195fa2e27615bae0a86956a3c90a)
(cherry picked from commit f6f1d13addea504ff7ed6ec87276d1cfdfcf2013)
(cherry picked from commit 9c0eebb55ceb6a7edc50e414b4be19faf256bcda)
Co-authored-by: Luca Auer <[email protected]>
(cherry picked from commit 1ff9a5625c442be1c9504df0f0eabdaf24aa2fda)
(cherry picked from commit 6f601a18c5beb78a70a94471abc2960fb37199b4)
(cherry picked from commit b924d582f459835f533fa54badbe129eede4388f)
(cherry picked from commit 5be5a4e81978954713da6f7faa24cc9956c823e9)
(cherry picked from commit 42c7329a9e17ab15c0dc1c1f33eabf54286f9339)
(cherry picked from commit 2248bdac546914492b0adf75425915b899749900)
(cherry picked from commit 27749fc583527ab1360594a69ef586a4311c93f5)
(cherry picked from commit 3f645294126cde62edb92e8d487659519c8b10ac)
Co-authored-by: Cuong-Tran <[email protected]>
Co-authored-by: Cuong-Tran <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eo/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ko/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/my/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/vi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Co-authored-by: Ai Ai Ecchi <[email protected]> Co-authored-by: Alexandre Dhooge <[email protected]> Co-authored-by: Cuong Tran <[email protected]> Co-authored-by: Dexroneum <[email protected]> Co-authored-by: Eduard Ereza Martínez <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: Hualiang <[email protected]> Co-authored-by: Infy's Tagalog Translations <[email protected]> Co-authored-by: Jakub Szafranek13 Fabijan <[email protected]> Co-authored-by: Lyfja <[email protected]> Co-authored-by: Milo Ivir <[email protected]> Co-authored-by: MuhamadSyabitHidayattulloh <[email protected]> Co-authored-by: Swyter <[email protected]> Co-authored-by: Throw Away <[email protected]> Co-authored-by: ZerOriSama <[email protected]> Co-authored-by: akir45 <[email protected]> Co-authored-by: clukki <[email protected]> Co-authored-by: momoehab <[email protected]> Co-authored-by: yumekon <[email protected]> Co-authored-by: ɴᴇᴋᴏ <[email protected]> Co-authored-by: 안세훈 <[email protected]> (cherry picked from commit 7c7d35e2c64d4f85b0db431fbe18408698af9c6e)
Co-authored-by: NarwhalHorns <[email protected]> Co-authored-by: AntsyLich <[email protected]>
Co-authored-by: NarwhalHorns <[email protected]>
Co-authored-by: NarwhalHorns <[email protected]>
Co-authored-by: AntsyLich <[email protected]>
…e screen Co-authored-by: AntsyLich <[email protected]>
(cherry picked from commit 5b85084d0a90b241fdf1d3ad018a27b49db15f12)
(cherry picked from commit 1e6c35d887e7116c4a1d331afefaabf7c32bb53a)
Co-authored-by: Cuong-Tran <[email protected]>
Co-authored-by: AntsyLich <[email protected]> Co-authored-by: jeremiejig <[email protected]>
Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/el/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eo/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translation: Mihon/Mihon Co-authored-by: Dexroneum <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: Jakub Szafranek13 Fabijan <[email protected]> Co-authored-by: KraXen <[email protected]> Co-authored-by: Lyfja <[email protected]> Co-authored-by: Milo Ivir <[email protected]> Co-authored-by: Pitpe11 <[email protected]> Co-authored-by: Swyter <[email protected]> Co-authored-by: ZerOriSama <[email protected]> (cherry picked from commit 565379779f82ee7dfdad45e251d82ff73dc3b7b2)
(cherry picked from commit 171a06a8baccae7fb21d2c60150639941747d90c)
Co-authored-by: p (cherry picked from commit 84265febf3ce24d71994ced2b81215f858430d4e)
Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/cs/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/vi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Co-authored-by: Filip Jaruška <[email protected]> Co-authored-by: Nguyễn Trung Đức <[email protected]> Co-authored-by: ɴᴇᴋᴏ <[email protected]> (cherry picked from commit cc3f640faa7df9f2a64976d2639e6dfd60ebe213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last commit merged: mihonapp/mihon@f9f938f