fix: prefetch images for connection error - handle retry#504
Merged
bluestreak01 merged 4 commits intomainfrom Nov 29, 2025
Merged
fix: prefetch images for connection error - handle retry#504bluestreak01 merged 4 commits intomainfrom
bluestreak01 merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes image loading issues during connection errors by implementing image prefetching with base64 data URLs. When a connection error occurs, preloaded images can be displayed without requiring network access, and the retry button now attempts to reconnect instead of forcing a full page reload.
Key Changes:
- Implemented image prefetching mechanism that converts images to base64 data URLs
- Modified the retry button to call
fetchAllinstead of reloading the page - Updated
fetchAllto support conditional error message display via aswitchViewparameter
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/providers/SettingsProvider/index.tsx | Added image prefetching logic, modified retry button behavior to use fetchAll instead of page reload, and converted fetchAll to a memoized callback with conditional error messaging |
| src/components/CenteredLayout/index.tsx | Added support for preloaded images prop to display cached image data |
| e2e/questdb | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
bluestreak01
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.