Skip to content

fix(web-console): declare variable highlighting in editor & query parameter parsing in chart request#452

Merged
bluestreak01 merged 4 commits intomainfrom
fix/variable-highlighting
Jul 10, 2025
Merged

fix(web-console): declare variable highlighting in editor & query parameter parsing in chart request#452
bluestreak01 merged 4 commits intomainfrom
fix/variable-highlighting

Conversation

@emrberk
Copy link
Copy Markdown
Collaborator

@emrberk emrberk commented Jul 8, 2025

Variable highlighting:
Screenshot 2025-07-10 at 15 15 51

While creating a chart we use /exec with query parameter src=vis. For this query:

select x as 'test1,test2', x as test3 from long_sequence(10);

we send query parameter cols="test1,test2","test3" now, instead of cols=test1,test2,test3, which is misleading for the server.

@emrberk emrberk requested a review from nwoolmer July 8, 2025 19:38
nwoolmer
nwoolmer previously approved these changes Jul 9, 2025
@emrberk emrberk changed the title feat(web-console): declare variable highlighting fix(web-console): declare variable highlighting in editor & query parameter parsing in charts Jul 10, 2025
@emrberk emrberk changed the title fix(web-console): declare variable highlighting in editor & query parameter parsing in charts fix(web-console): declare variable highlighting in editor & query parameter parsing in chart request Jul 10, 2025
@bluestreak01 bluestreak01 merged commit 3a9716d into main Jul 10, 2025
4 checks passed
@bluestreak01 bluestreak01 deleted the fix/variable-highlighting branch July 10, 2025 13:13
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants