feat(web-console): dynamic query status indicators, run button per query, run all queries in tab#437
Merged
bluestreak01 merged 60 commits intomainfrom Jul 3, 2025
Merged
Conversation
…cator, use virtualization for performance
…on race condition
emrberk
changed the title
…log for notifications+executionrefs
emrberk
changed the title
emrberk
changed the title
bluestreak01
previously approved these changes
Jul 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds per-query run controls, dynamic status indicators, and script execution features in the web console editor, along with query-specific notifications and logging improvements.
- Introduces new action types, state shape, and selectors to track query notifications and execution state per buffer.
- Adds UI components (
ButtonBar,QueryDropdown,LoadingNotification) and integrates run/explain buttons for individual queries and whole-script execution. - Extends the Monaco editor helpers to detect, run, and highlight multiple queries, including selections and error ranges.
Reviewed Changes
Copilot reviewed 34 out of 69 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-console/src/store/Query/types.ts | Expanded QueryStateShape, added new types (RunningType, QueryKey, QueriesToRun). |
| packages/web-console/src/store/Query/selectors.ts | New selectors for queryNotifications, activeNotification, queriesToRun. |
| packages/web-console/src/store/Query/reducers.ts | Refactored notification handling, per-buffer storage, and running enum. |
| packages/web-console/src/scenes/Schema/VirtualTables/index.tsx | Switched from dispatching notifications to toasts for schema actions; removed user feedback on column errors. |
| packages/web-console/src/scenes/Notifications/index.tsx | Scoped notifications per buffer, added clear-per-buffer callback. |
| packages/web-console/src/scenes/Editor/Monaco/utils.ts | Massive updates to query parsing/utilities for multi-query support. |
| packages/web-console/src/scenes/Editor/ButtonBar/index.tsx | New ButtonBar component for run controls with dropdown options. |
Files not reviewed (1)
- .pnp.cjs: Language not supported
Comments suppressed due to low confidence (1)
packages/web-console/src/theme/index.ts:47
- [nitpick] The new color key
greenDarkercould be inconsistent with other naming (e.g.,greenDark). Verify that naming conventions for shade modifiers are consistent across the theme.
greenDarker: "#00aa3b",
bluestreak01
approved these changes
Jul 3, 2025
This was referenced Jul 4, 2025
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
…ery, run all queries in tab (questdb#437)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.