fix(core): disable materialized view parallel SQL on low-core machines#6891
Merged
fix(core): disable materialized view parallel SQL on low-core machines#6891
Conversation
Machines with fewer than 4 available processors no longer enable parallel SQL execution (filter, group by, top-k, horizon join, window join, parquet read) by default. Users can still explicitly enable parallel execution via configuration properties. This restores a previous safeguard that was inadvertently removed. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ideoma
previously approved these changes
Mar 20, 2026
This reverts commit 0ab41d8.
Machines with fewer than 4 available processors now default cairo.mat.view.parallel.sql.enabled to false. Users can still explicitly enable it via configuration. This is a narrower safeguard than the reverted commit which disabled all parallel SQL features on low-core machines. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The parallel SQL CPU restriction was reverted, so these test workarounds that force-enabled parallel filter, group by, top-k, and window join are no longer needed. defaultParallelSqlEnabled is back to `queryWorkers > 0` which is true on any machine. Co-Authored-By: Claude Opus 4.6 <[email protected]>
ideoma
changed the title
ideoma
previously approved these changes
Mar 24, 2026
PropServerConfigurationTest.testAllDefaults: make the isMatViewParallelSqlEnabled assertion conditional on CPU count, matching the new default (cpuAvailable >= 4). MatViewTest.testQueryError and testRecursiveInvalidationOnFailedRefresh: force CAIRO_MAT_VIEW_PARALLEL_SQL_ENABLED=true via setProperty so that npe() in the WHERE clause goes through the parallel reduce path and produces the expected "unexpected reduce error" message regardless of core count. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
[PR Coverage check]😍 pass : 1 / 1 (100.00%) file detail
|
ideoma
approved these changes
Mar 24, 2026
ideoma
pushed a commit
that referenced
this pull request
Mar 26, 2026
ideoma
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PropServerConfigurationdefaultscairo.mat.view.parallel.sql.enabledtofalseon machines with fewer than 4 available processors