perf(sql): speed up ORDER BY on SYMBOL columns#6870
Merged
bluestreak01 merged 47 commits intomasterfrom Mar 13, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # core/src/main/resources/io/questdb/bin/linux-aarch64/libquestdb.so # core/src/main/resources/io/questdb/bin/windows-x86-64/libquestdb.dll
bluestreak01
previously approved these changes
Mar 13, 2026
Contributor
[PR Coverage check]😍 pass : 300 / 316 (94.94%) file detail
|
bluestreak01
approved these changes
Mar 13, 2026
maciulis
pushed a commit
to maciulis/questdb
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #6862
Summary
DirectIntListused when building symbol rank maps. Replaces it with in-place permutation inversion after quicksort, reducing extra space from O(N) to O(1) (N = symbol count). Mainly benefits high-cardinality symbol columns.getSym()+Chars.compare) with rank-based comparison (getInt()+ rank map lookup) when sorting SYMBOL columns that have static symbol tables. At cursor open, a rank map maps each symbol key to its alphabetical rank; the comparator then compares ranks instead of strings.CachedWindowRecordCursorFactory), and window function internal comparators (rank(),percent_rank()).CAST(str AS SYMBOL)) fall back to the originalgetSym()+Chars.comparepath.Benchmark
R-B tree sort path (ORDER BY includes a STRING column, so encoded sort is not used):
7,235,498 rows: