fix(sql): fix WINDOW JOIN INCLUDE PREVAILING dropping prevailing row when window has matches#6868
Merged
bluestreak01 merged 1 commit intomasterfrom Mar 11, 2026
Merged
Conversation
…when window has matches
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
approved these changes
Mar 11, 2026
Contributor
[PR Coverage check]😍 pass : 4 / 4 (100.00%) file detail
|
mtopolnik
pushed a commit
that referenced
this pull request
Mar 12, 2026
…when window has matches (#6868)
maciulis
pushed a commit
to maciulis/questdb
that referenced
this pull request
Mar 16, 2026
…when window has matches (questdb#6868)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WINDOW JOIN with
INCLUDE PREVAILINGincludes right-table rows within the time window plus the most recent right row with a timestamp equal to or earlier than the window start.The non-vectorized fast cursor (
WindowJoinWithPrevailingFastRecordCursor) compared the first window match against the window end instead of the window start, making the prevailing row effectively never included when the window already contained matches:The vectorized variant (WindowJoinFastVectRecordCursor) already used the correct comparison. This bug only affected queries using non-vectorizable aggregates (e.g., max(concat(...))) with symbol-keyed WINDOW JOIN and INCLUDE PREVAILING.
Test plan
testFastNonVectorizedPrevailingWithWindowMatchesusesmax(concat(r.val, ''))to force the non-vectorized fast path with a prevailing row (val=99) outside the window alongside two window matches (val=20, 30).Expects max="99"; without the fix, returns "30".
Cross-checks with vectorized count(*) expecting 3 rows.