core/src/test/java/io/questdb/test/griffin/AlterTableAlterColumnTest.java (2)

170-171: Place the new test method in sorted order with peer methods.

Move testQuotedColumnName to the correct alphabetical position among instance test methods.

As per coding guidelines: "Java class members are grouped by kind (static vs. instance) and visibility, and sorted alphabetically. When adding new methods or fields, insert them in the correct alphabetical position among existing members of the same kind."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/src/test/java/io/questdb/test/griffin/AlterTableAlterColumnTest.java`
around lines 170 - 171, The new instance test method testQuotedColumnName in
class AlterTableAlterColumnTest must be relocated so instance test methods
remain alphabetically ordered; move the entire testQuotedColumnName method block
to the alphabetical position among other instance `@Test` methods in
AlterTableAlterColumnTest (compare method name strings) so it fits the existing
sorting convention for instance members.

---

170-181: Broaden coverage to all affected quoted-identifier paths.

Please add assertions for at least one single-quoted column token and one ALTER MATERIALIZED VIEW ... ALTER COLUMN case, since the parser change affects both paths.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/src/test/java/io/questdb/test/griffin/AlterTableAlterColumnTest.java`
around lines 170 - 181, Extend testQuotedColumnName (or add a new test) to cover
the remaining quoted-identifier parsing paths: add at least one assertion that
uses a single-quoted column token (e.g., execute("ALTER TABLE test_quoted ALTER
COLUMN 'MY_COL' ADD INDEX"/similar) to exercise the single-quote token branch)
and add a case that runs ALTER MATERIALIZED VIEW ... ALTER COLUMN (e.g., create
a materialized view and call execute("ALTER MATERIALIZED VIEW mv_name ALTER
COLUMN \"MY_COL\" ADD INDEX" and a corresponding DROP/ CACHE/NOCACHE) to
exercise the materialized view code path), ensuring the same operations as in
testQuotedColumnName (ADD INDEX, DROP INDEX, CACHE, NOCACHE) are asserted;
update test method names or add a new test method accordingly so both parser
branches are covered.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

core/src/test/java/io/questdb/test/cairo/mv/MatViewTest.java (1)

309-314: Normalize SQL keyword casing in new test SQL strings.

The new CREATE TABLE / SELECT ... SAMPLE BY strings use lowercase keywords; please align with test SQL casing conventions.

Suggested diff

-            executeWithRewriteTimestamp(
-                    "create table base_price (" +
-                            "  \"MY_SYM\" symbol, price double, ts `#TIMESTAMP`" +
-                            ") timestamp(ts) partition by DAY WAL"
-            );
-            createMatView("select \"MY_SYM\", last(price) as price, ts from base_price sample by 1h");
+            executeWithRewriteTimestamp(
+                    "CREATE TABLE base_price (" +
+                            "  \"MY_SYM\" SYMBOL, price DOUBLE, ts `#TIMESTAMP`" +
+                            ") TIMESTAMP(ts) PARTITION BY DAY WAL"
+            );
+            createMatView("SELECT \"MY_SYM\", last(price) AS price, ts FROM base_price SAMPLE BY 1h");

As per coding guidelines: In SQL statements within test code, use UPPERCASE for SQL keywords (CREATE TABLE, INSERT, SELECT ... AS ... FROM, etc.).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/src/test/java/io/questdb/test/cairo/mv/MatViewTest.java` around lines
309 - 314, The SQL strings in MatViewTest (around the create table for
base_price and the createMatView call) use lowercase SQL keywords; update the
literals so SQL keywords are UPPERCASE (e.g., "CREATE TABLE", "TIMESTAMP",
"PARTITION BY DAY WAL", "SELECT", "AS", "FROM", "SAMPLE BY") while keeping
identifiers like "MY_SYM", column names, and the function call
createMatView(...) unchanged; ensure both the CREATE TABLE string and the SELECT
... SAMPLE BY string follow the test code's uppercase SQL keyword convention.