core/src/test/java/io/questdb/test/PropServerConfigurationTest.java (1)

2102-2102: Consider adding coverage for sequential and invalid values.

This change validates random, but adding assertions for sequential and invalid-token fallback would lock all parser branches for the new option.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/src/test/java/io/questdb/test/PropServerConfigurationTest.java` at line
2102, Add two more assertions in PropServerConfigurationTest to cover the
remaining parser branches for wal writer madvise: assert that
configuration.getWalWriterMadviseMode() equals Files.POSIX_MADV_SEQUENTIAL when
the property is set to "sequential", and assert the fallback behavior (the
expected default constant) when an invalid token is provided; update the test
setup that feeds the property (the same place where "random" is exercised) to
supply the "sequential" and an invalid value and verify the returned constants
to lock the parser branches for Files.POSIX_MADV_SEQUENTIAL,
Files.POSIX_MADV_RANDOM and the invalid-token fallback.

core/src/main/java/io/questdb/PropServerConfiguration.java (1)

2260-2279: Use enhanced switch to decode madvise mode and extract the sentinel constant.

This method is a strong fit for an enhanced switch expression, consistent with patterns already used elsewhere in this class (e.g., getLineTimestampUnit). Extract the sentinel value -1 into a named constant for clarity.

♻️ Proposed refactor

+    private static final int WAL_WRITER_MADVISE_NONE = -1;
+
     private int getWalWriterMadviseMode(Properties properties, `@Nullable` Map<String, String> env, ConfigPropertyKey key) throws ServerConfigurationException {
         final String mode = getString(properties, env, key, "none");
-
-        // must not be null because we provided non-null default value
-        assert mode != null;
-
-        if (Chars.equalsLowerCaseAscii(mode, "none")) {
-            return -1;
-        }
-
-        if (Chars.equalsLowerCaseAscii(mode, "sequential")) {
-            return Files.POSIX_MADV_SEQUENTIAL;
-        }
-
-        if (Chars.equalsLowerCaseAscii(mode, "random")) {
-            return Files.POSIX_MADV_RANDOM;
-        }
-
-        throw ServerConfigurationException.forInvalidKey(key.getPropertyPath(), mode);
+        assert mode != null;
+        return switch (mode.toLowerCase()) {
+            case "none" -> WAL_WRITER_MADVISE_NONE;
+            case "sequential" -> Files.POSIX_MADV_SEQUENTIAL;
+            case "random" -> Files.POSIX_MADV_RANDOM;
+            default -> throw ServerConfigurationException.forInvalidKey(key.getPropertyPath(), mode);
+        };
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/src/main/java/io/questdb/PropServerConfiguration.java` around lines 2260
- 2279, Refactor getWalWriterMadviseMode to use an enhanced switch on the
lowercased mode string and extract the sentinel -1 into a named constant (e.g.,
POSIX_MADV_NONE) for readability; replace the chain of
Chars.equalsLowerCaseAscii checks with something like switch
(Chars.toLowerCaseAscii(mode)) { case "none" -> POSIX_MADV_NONE; case
"sequential" -> Files.POSIX_MADV_SEQUENTIAL; case "random" ->
Files.POSIX_MADV_RANDOM; default -> throw
ServerConfigurationException.forInvalidKey(key.getPropertyPath(), mode); } while
keeping the method signature and null-safety assertions unchanged.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro