#!/bin/bash

# Fetch PR details
gh pr view 6822 --json title,body,files,additions,deletions

# Get the modified files
echo "=== AbstractAsOfJoinFastRecordCursor.java ==="
cat core/src/main/java/io/questdb/griffin/engine/join/AbstractAsOfJoinFastRecordCursor.java

echo -e "\n=== WindowJoinTimeFrameHelper.java ==="
cat core/src/main/java/io/questdb/griffin/engine/join/WindowJoinTimeFrameHelper.java

# Check for tests related to these changes
echo -e "\n=== Finding related test files ==="
fd -e java -x echo {} \; | rg -i "asof.*join.*test|window.*join.*test" || echo "Search completed"

# Look for TimeFrameCursor interface to understand seekEstimate contract
echo -e "\n=== TimeFrameCursor interface ==="
fd TimeFrameCursor.java -x cat {}

#!/bin/bash

# Get the test files to check coverage
echo "=== AsOfJoinTest.java new tests ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinTest.java | head -200

echo -e "\n=== AsOfJoinNoKeyTest.java new tests ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinNoKeyTest.java | head -200

echo -e "\n=== WindowJoinTest.java new tests ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java | head -200

# Check TimeFrameCursorImpl to understand seekEstimate implementation
echo -e "\n=== TimeFrameCursorImpl seekEstimate implementation ==="
ast-grep --pattern 'seekEstimate($$$) {
  $$$
}'

# Look for partition ceiling calculation
echo -e "\n=== Searching for partition ceiling/estimate logic ==="
rg -n "estimatePartitionHi|getTimestampEstimate" --type=java -A 3 -B 1

#!/bin/bash

# Get full test additions to check coverage
echo "=== Full AsOfJoinTest.java additions ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinTest.java

echo -e "\n=== Full AsOfJoinNoKeyTest.java additions ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinNoKeyTest.java

echo -e "\n=== WindowJoinTest.java additions (first 300 lines) ==="
git diff HEAD~1 HEAD -- core/src/test/java/io/questdb/test/griffin/engine/join/WindowJoinTest.java | head -300

# Get TimeFrameCursorImpl seekEstimate implementation
echo -e "\n=== TimeFrameCursorImpl.java seekEstimate ==="
cat core/src/main/java/io/questdb/griffin/engine/table/TimeFrameCursorImpl.java | grep -A 30 "public void seekEstimate"

# Check ConcurrentTimeFrameCursorImpl seekEstimate
echo -e "\n=== ConcurrentTimeFrameCursorImpl.java seekEstimate ==="
cat core/src/main/java/io/questdb/griffin/engine/table/ConcurrentTimeFrameCursorImpl.java | grep -A 30 "public void seekEstimate"

# Look for timestamp scale/conversion patterns in tests
echo -e "\n=== Checking for timestamp scale tests ==="
rg -n "TimestampType|MICROS|NANOS" core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinTest.java core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinNoKeyTest.java core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java 2>/dev/null | head -50

#!/bin/bash

# Check the actual test files to see if they were added in this PR
echo "=== Checking git status for test files ==="
git log --oneline -1 --name-status

# Look at findSeekEstimate static method implementation
echo -e "\n=== TimeFrameCursor.findSeekEstimate static method ==="
rg -n "static void findSeekEstimate" -A 30 --type=java

# Check for timestamp conversion edge cases
echo -e "\n=== Checking timestamp conversion in AbstractAsOfJoinFastRecordCursor ==="
cat core/src/main/java/io/questdb/griffin/engine/join/AbstractAsOfJoinFastRecordCursor.java | grep -B 5 -A 10 "nativeTimestamp"

# Look for similar patterns in WindowJoinTimeFrameHelper
echo -e "\n=== Checking timestamp conversion in WindowJoinTimeFrameHelper ==="
cat core/src/main/java/io/questdb/griffin/engine/join/WindowJoinTimeFrameHelper.java | grep -B 5 -A 10 "nativeTimestamp"

# Check the partition index calculation more carefully
echo -e "\n=== Full populatePartitionTimestamps method ==="
rg -n "populatePartitionTimestamps" -A 20 --type=java

# Look at how HORIZON JOIN does it
echo -e "\n=== HorizonJoinTimeFrameHelper seekEstimate usage ==="
rg -n "seekEstimate" core/src/main/java/io/questdb/griffin/engine/table/HorizonJoinTimeFrameHelper.java -B 5 -A 10

Learnt from: javier
Repo: questdb/questdb PR: 0
File: :0-0
Timestamp: 2026-02-06T18:22:28.130Z
Learning: In questdb/questdb, for PRs requested by javier, provide line-cited, push-back style reviews with concrete follow-ups (tests, diffs, and performance considerations).

Learnt from: javier
Repo: questdb/questdb PR: 0
File: :0-0
Timestamp: 2026-02-06T18:22:28.130Z
Learning: For questdb/questdb, javier expects a rigorous, push-back style review; always include concrete line-cited findings and propose targeted tests/fixes when reviewing javier’s PRs.

Learnt from: jerrinot
Repo: questdb/questdb PR: 0
File: :0-0
Timestamp: 2026-02-04T11:18:36.492Z
Learning: For PRs by jerrinot, always use a thorough and critical review mode: question design decisions, challenge assumptions, scrutinize implementations for edge cases and potential issues, and avoid superficial validation. They prefer hard-core reviews that push back on the code.

Learnt from: bluestreak01
Repo: questdb/questdb PR: 6673
File: core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java:2616-2618
Timestamp: 2026-01-19T21:43:19.228Z
Learning: In test `testWindowJoinFailsWhenSlaveDoesNotSupportTimeFrames` in `core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java`, the use of `AND` between timestamp equality conditions (e.g., `ts = 'X' AND ts = 'Y'`) is intentional to prevent intrinsic interval creation. This ensures the window join fails as expected when the slave doesn't support time frames, which is necessary after PR `#6673` added OR timestamp intrinsics recognition.