fix(sql): fix stale interval evaluation for tick expressions with date variables in filter functions#6798
Merged
bluestreak01 merged 2 commits intomasterfrom Feb 20, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
[PR Coverage check]😍 pass : 22 / 28 (78.57%) file detail
|
maciulis
pushed a commit
to maciulis/questdb
that referenced
this pull request
Feb 22, 2026
…e variables in filter functions (questdb#6798)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6797
Summary
$now,$today, etc.) used as filterpredicates — e.g.,
WHERE now() IN '$now-100s..$now'— resolved$nowonce atcompile time and cached the resulting interval as static timestamps. On repeated
execution of a cached SQL statement, the interval never updated, causing the filter
to return 0 rows once
now()moved past the originally computed range.fixed in fix(sql): compile tick expressions with date variables into IR for zero-parse evaluation when executing caches SQL statements #6780 to compile such expressions into IR via
CompiledTickExpression.The filter function path in
InTimestampTimestampFunctionFactorywas not updatedand still used the static
EqTimestampStrConstantFunction.through
CompiledTickExpression, which re-evaluates the interval from IR on eachexecution via
init().Test plan
testNowInTickExprWithDateVariableReevaluatesOnCachedExecutioncompilesWHERE now() IN '$now-100s..$now'once, executes the factory at T1 (expects 1 row),advances
now()by 200s, and re-executes (expects 1 row again)InTimestampTimestampTesttests pass (no regressions in constant andbind-variable interval paths)
🤖 Generated with Claude Code