fix(ilp): fix assertion error in ILP decimal parser on malformed input#6772
Merged
bluestreak01 merged 1 commit intomasterfrom Feb 12, 2026
Merged
fix(ilp): fix assertion error in ILP decimal parser on malformed input#6772bluestreak01 merged 1 commit intomasterfrom
bluestreak01 merged 1 commit intomasterfrom
Conversation
bluestreak01
added
Bug
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
[PR Coverage check]😍 pass : 1 / 1 (100.00%) file detail
|
maciulis
pushed a commit
to maciulis/questdb
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was discovered by Team Atlanta (@LeeSinLiang and @occia) 👍
Summary
lenbyte inDecimalBinaryFormatParseras unsigned (& 0xFF) instead of signed. A malformed ILP message with a highlenbyte (e.g.0x80) was interpreted as negative, which skipped theVALUESparsing state and leftunscaledValuesempty. The subsequentload()call then hit anArrayIndexOutOfBoundsExceptionaccessing index 0 of the empty list.Test plan
LineTcpReceiverTest#testMalformedBinaryDecimalDoesNotCrash— sends a malformed 83-byte payload to ILP TCP, then sends a valid ILP message and asserts it was ingested correctly🤖 Generated with Claude Code