fix(core): fix intermittent backup failures on Windows caused by file access problems#6748
Merged
bluestreak01 merged 9 commits intomasterfrom Feb 7, 2026
Merged
fix(core): fix intermittent backup failures on Windows caused by file access problems#6748bluestreak01 merged 9 commits intomasterfrom
bluestreak01 merged 9 commits intomasterfrom
Conversation
…lure When QuestDB fails to start due to configuration errors (e.g., invalid cron expression), there's a race condition where hello.txt is created briefly then deleted by JVM's deleteOnExit hook. This caused confusing error messages from cat/rm trying to access the removed file. Redirect stderr to /dev/null for cat and rm commands to suppress these cosmetic errors. The actual startup failure is logged elsewhere. Also quote $HELLO_FILE for robustness with paths containing spaces. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RaphDal
changed the title
RaphDal
changed the title
RaphDal
changed the title
bluestreak01
previously approved these changes
Feb 7, 2026
bluestreak01
approved these changes
Feb 7, 2026
Contributor
[PR Coverage check]😞 fail : 0 / 3 (00.00%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of memory-mapped file handling for columns, specifically addressing issues on Windows platforms. The key change is the introduction of a fallback mechanism for mapping files on Windows, which gracefully handles transient permission errors by falling back to an anonymous memory map populated by reading the file contents directly. This ensures that file mapping works even when Windows-specific file locking or permission issues occur.
Reason for the change
We observed file mapping failures on Windows with "Access Denied" even if the file has been successfully opened earlier.
Platform-specific file mapping improvements:
Added a new
map_file_with_fallbackfunction inMappedColumnthat, on Windows, attempts a standard memory map and falls back to an anonymous map with direct file reading if a permission error occurs. On non-Windows platforms, the original mapping logic is retained. [1] [2]Updated all uses of
Mmap::mapinMappedColumnto use the newmap_file_with_fallbackfunction, improving robustness when mapping both data and auxiliary files. [1] [2]