fix(core): suppress error output in print-hello.sh during startup failure#6738
Merged
bluestreak01 merged 1 commit intomasterfrom Feb 2, 2026
Merged
fix(core): suppress error output in print-hello.sh during startup failure#6738bluestreak01 merged 1 commit intomasterfrom
bluestreak01 merged 1 commit intomasterfrom
Conversation
…lure When QuestDB fails to start due to configuration errors (e.g., invalid cron expression), there's a race condition where hello.txt is created briefly then deleted by JVM's deleteOnExit hook. This caused confusing error messages from cat/rm trying to access the removed file. Redirect stderr to /dev/null for cat and rm commands to suppress these cosmetic errors. The actual startup failure is logged elsewhere. Also quote $HELLO_FILE for robustness with paths containing spaces. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mtopolnik
approved these changes
Feb 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cat/rmerror messages when QuestDB fails to start due to configuration errors$HELLO_FILEfor robustness with paths containing spacesProblem
When QuestDB fails to start (e.g., invalid cron expression in enterprise), there's a race condition:
hello.txtwithdeleteOnExit()deleteOnExit()removeshello.txtprint-hello.shtries to read/remove the file → error messagesSolution
Redirect stderr to
/dev/nullforcatandrmcommands. The actual startup failure is logged instdout-*.txt.