fix(pgwire): prepared batch with same SQL returns corrupted results#6706
Merged
bluestreak01 merged 4 commits intomasterfrom Jan 26, 2026
Merged
fix(pgwire): prepared batch with same SQL returns corrupted results#6706bluestreak01 merged 4 commits intomasterfrom
bluestreak01 merged 4 commits intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kafka1991
changed the title
jerrinot
reviewed
Jan 26, 2026
Contributor
[PR Coverage check]😍 pass : 3 / 3 (100.00%) file detail
|
jerrinot
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing multiple commands with the same SQL but different parameters caused the second command to return corrupted data.
Root cause:
msgBindCopySelectFormatCodes()checkedfactory != nullto determine if format codes should be set. When a prepared statement is reused viacopyIfExecuted(), the new entry hasfactory=null(not copied), causing format codes to be skipped. The client then misinterpreted binary/text format.Fix: Replace
factory != nullwithhasResultSet()which usessqlTypeFixes #6703