Walkthrough

This PR adds validation to prevent designated timestamp columns from being used as join keys in ASOF/LT joins. It introduces a new validation method that raises a proper SqlException instead of allowing an AssertionError to occur when a timestamp is incorrectly specified in multi-key join conditions.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(sql): optimize error msg when invalid column references in JOIN queries #6332 — Adds column-existence checks in SqlCodeGenerator join validation paths
• feat(sql): optimized ASOF JOIN on single symbol key where RHS symbol is low-frequency #6208 — Refactors ASOF join construction with symbol/column access helpers and optimization selection
• fix(sql): fix ASOF JOIN crash when ON clause has symbol and other columns #6634 — Addresses ASOF/LT join handling when symbol and timestamp appear in ON clause

Suggested labels

Bug, SQL

Suggested reviewers

• bluestreak01

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@CodeRabbit Please review this.

@mtopolnik: I'll review the changes in this PR.

Learnt from: bluestreak01
Repo: questdb/questdb PR: 6673
File: core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java:2616-2618
Timestamp: 2026-01-19T21:43:19.228Z
Learning: In test `testWindowJoinFailsWhenSlaveDoesNotSupportTimeFrames` in `core/src/test/java/io/questdb/test/griffin/WindowJoinTest.java`, the use of `AND` between timestamp equality conditions (e.g., `ts = 'X' AND ts = 'Y'`) is intentional to prevent intrinsic interval creation. This ensures the window join fails as expected when the slave doesn't support time frames, which is necessary after PR `#6673` added OR timestamp intrinsics recognition.

[PR Coverage check]

😍 pass : 502 / 579 (86.70%)

file detail