Skip to content

perf(core): avoid contention across concurrent queries on expensive file operation#6688

Merged
bluestreak01 merged 8 commits intomasterfrom
mt_better-partition-reload
Jan 22, 2026
Merged

perf(core): avoid contention across concurrent queries on expensive file operation#6688
bluestreak01 merged 8 commits intomasterfrom
mt_better-partition-reload

Conversation

@mtopolnik
Copy link
Copy Markdown
Contributor

@mtopolnik mtopolnik commented Jan 21, 2026

Two changes:

  1. Avoid closing a partition when it's not actually open (is in standby for lazy open)
  2. Perform mmap outside of synchronized block in MmapCache

@mtopolnik mtopolnik added the Core Related to storage, data type, etc. label Jan 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 21, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jerrinot jerrinot self-requested a review January 21, 2026 14:08
jerrinot
jerrinot reviewed Jan 21, 2026
View reviewed changes
jerrinot
jerrinot reviewed Jan 21, 2026
View reviewed changes
@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Jan 21, 2026

[PR Coverage check]

😍 pass : 54 / 58 (93.10%)

file detail

path covered line new line coverage
🔵 io/questdb/std/MmapCache.java 53 57 92.98%
🔵 io/questdb/cairo/TableReader.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit b4c4b81 into master Jan 22, 2026
43 checks passed
@bluestreak01 bluestreak01 deleted the mt_better-partition-reload branch January 22, 2026 09:57
mtopolnik added a commit that referenced this pull request Jan 22, 2026
@mtopolnik
perf(core): avoid contention across concurrent queries on expensive f…
e9ee7a9 
…ile operation (#6688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerrinot jerrinot jerrinot approved these changes

Assignees

No one assigned

Labels

Core Related to storage, data type, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtopolnik @glasstiger @jerrinot @bluestreak01