fix(sql): fix ASOF JOIN crash when ON clause has symbol and other columns by jerrinot · Pull Request #6634 · questdb/questdb

jerrinot · 2026-01-13T12:36:37Z

ASOF JOIN queries with a symbol column AND another column in the ON clause would throw UnsupportedOperationException when using the Light join factory.

The single-symbol optimization was incorrectly applied when there were multiple join keys, creating a map that only supported INT keys while the record copier attempted to write all column types.

In some cases it does not crash, but it can silently return wrong results.

…umns ASOF JOIN queries with a symbol column AND another column in the ON clause would throw UnsupportedOperationException when using the Light join factory. The single-symbol optimization was incorrectly applied when there were multiple join keys, creating a map that only supported INT keys while the record copier attempted to write all column types.

coderabbitai · 2026-01-13T12:36:44Z

Walkthrough

A modification to the ASOF join optimization in SqlCodeGenerator tightens the fallback condition for single-symbol short-circuit optimization by requiring exactly one join key column on the master side. A corresponding test method is added to verify ASOF join behavior with symbol and timestamp columns.

Changes

Cohort / File(s)	Summary
ASOF Join Optimization Logic `core/src/main/java/io/questdb/griffin/SqlCodeGenerator.java`	Adds column count validation to the single-symbol join fallback condition; optimization now triggers only when `listColumnFilterA.getColumnCount() == 1 && isSingleSymbolJoin(symbolShortCircuit)` is true, affecting both keyed and non-keyed ASOF join paths
ASOF Join Test Coverage `core/src/test/java/io/questdb/test/griffin/engine/join/AsOfJoinTest.java`	Adds test method `testAsOfJoinWithSymbolAndTimestampInOnClause()` to verify ASOF JOIN behavior with symbol and timestamp in ON clause; method appears to be declared twice (duplicate)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

perf(sql): improve performance of linear as-of join algo #6338: Modifies ASOF join single-symbol fast-path behavior in SqlCodeGenerator through addition of single-symbol ASOF cursor factory.
feat(sql): optimized ASOF JOIN on single symbol key where RHS symbol is low-frequency #6208: Refactors symbol short-circuiting logic in ASOF join optimization paths via AsofJoinColumnAccessHelper.
feat(sql): speed up ASOF JOIN on indexed symbol column #6158: Adjusts ASOF join selection logic between single-symbol short-circuit and indexed-ASOF-join paths.

Suggested labels

SQL

Suggested reviewers

bluestreak01
puzpuzpuz

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main fix: preventing ASOF JOIN crashes when the ON clause contains both symbol and other columns.
Description check	✅ Passed	The pull request description clearly explains the bug, root cause, and fix related to ASOF JOIN optimization.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jerrinot · 2026-01-13T12:38:09Z

@coderabbitai pls review

coderabbitai · 2026-01-13T12:38:58Z

🧩 Analysis chain

@jerrinot, I'll review the changes in this PR.

🏁 Script executed:

#!/bin/bash
# Fetch PR details
gh pr view 6634 --json title,body,files,additions,deletions

# Get the diff for this PR
gh pr diff 6634

Length of output: 4106

@jerrinot, I'll conduct a comprehensive review of this PR.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

glasstiger · 2026-01-13T13:53:37Z

[PR Coverage check]

😍 pass : 3 / 3 (100.00%)

file detail

	path	covered line	new line	coverage
🔵	io/questdb/griffin/SqlCodeGenerator.java	3	3	100.00%

follow-up of #6634

…umns (#6634)

jerrinot added the Bug Incorrect or unexpected behavior label Jan 13, 2026

jerrinot requested a review from mtopolnik January 13, 2026 12:37

jerrinot marked this pull request as draft January 13, 2026 12:42

jerrinot added 4 commits January 13, 2026 13:56

add column count check to AsOfJoinFast single-symbol path

7f4a13f

add column count check to AsOfJoinDenseSingleSymbol path

cab2ba6

another test

163e507

refactoring

31f5a3a

jerrinot marked this pull request as ready for review January 13, 2026 13:17

jerrinot added 2 commits January 13, 2026 14:18

CI trigger

3c1d0f2

what can be static should be static

488d7eb

mtopolnik approved these changes Jan 13, 2026

View reviewed changes

bluestreak01 merged commit baeb297 into master Jan 13, 2026
45 checks passed

bluestreak01 deleted the jh_asof_on_single_symbol_and_other_type branch January 13, 2026 15:48

jerrinot added a commit that referenced this pull request Jan 13, 2026

test(sql): add ASOF/LT JOIN fuzz test with multiple join keys

5395f07

follow-up of #6634

jerrinot mentioned this pull request Jan 13, 2026

test(sql): add ASOF/LT JOIN fuzz test with multiple join keys #6638

Draft

ideoma pushed a commit that referenced this pull request Jan 14, 2026

fix(sql): fix ASOF JOIN crash when ON clause has symbol and other col…

b044dc3

…umns (#6634)

bluestreak01 mentioned this pull request Jan 14, 2026

UnsupportedOperationException in Unordered4Map$Key.putLong during ASOF JOIN with CTE #6648

Closed

coderabbitai bot mentioned this pull request Jan 23, 2026

fix(sql): proper error message when timestamp used along another join key in ASOF/LT join #6698

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sql): fix ASOF JOIN crash when ON clause has symbol and other columns#6634

fix(sql): fix ASOF JOIN crash when ON clause has symbol and other columns#6634
bluestreak01 merged 7 commits intomasterfrom
jh_asof_on_single_symbol_and_other_type

jerrinot commented Jan 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

jerrinot commented Jan 13, 2026

Uh oh!

coderabbitai bot commented Jan 13, 2026

Uh oh!

glasstiger commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jerrinot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

jerrinot commented Jan 13, 2026

Uh oh!

coderabbitai bot commented Jan 13, 2026

Uh oh!

glasstiger commented Jan 13, 2026

[PR Coverage check]

file detail

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerrinot commented Jan 13, 2026 •

edited

Loading

coderabbitai bot commented Jan 13, 2026 •

edited

Loading