fix(sql): fix view metadata race conditions on replica#6627
Merged
bluestreak01 merged 5 commits intomasterfrom Jan 12, 2026
Merged
fix(sql): fix view metadata race conditions on replica#6627bluestreak01 merged 5 commits intomasterfrom
bluestreak01 merged 5 commits intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluestreak01
changed the title
bluestreak01
changed the title
bluestreak01
changed the title
glasstiger
reviewed
Jan 12, 2026
Contributor
[PR Coverage check]😍 pass : 21 / 23 (91.30%) file detail
|
glasstiger
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two race conditions in view state management that could cause incorrect view metadata on replicas:
Problem 1: Stale Updates
When multiple
ViewCompilerJobtasks run concurrently (e.g., during replica sync with random server restarts), a task that started earlier but completed later could overwrite a newer, correct view state.Example from failing test:
Solution: Add timestamp check in
updateViewState()- skip updates ifupdateTimestamp < viewState.getUpdateTimestamp().Problem 2: Empty Metadata on Creation
When a view is created:
createViewState()creates ViewState with empty ViewMetadata (no columns, no timestamp)If queries run between steps 2 and 3, they see empty
designatedTimestampintables().Solution: Pass the compiled
RecordMetadatafrom view creation directly tocreateViewState(), so proper column info is hydrated immediately.Changes
ViewCompilerJob.java: Add stale update timestamp checkViewStateStore.java: AddcreateViewState(ViewDefinition, RecordMetadata)overloadViewStateStoreImpl.java: Use passed metadata to create proper ViewMetadataViewState.java: Add constructor accepting ViewMetadataCairoEngine.java: Pass metadata to createView()SqlCompilerImpl.java: Pass factory metadata during view creationTest plan
ViewInvalidationTest- all 12 tests passViewsFunctionTest.testShowCreateView- passesViewReplicationTest.testReplicateTableDropInvalidateViewState- originally failing test🤖 Generated with Claude Code