perf(sql): speed up min/max aggregates on designated timestamp#6593
Merged
bluestreak01 merged 4 commits intomasterfrom Jan 5, 2026
Merged
perf(sql): speed up min/max aggregates on designated timestamp#6593bluestreak01 merged 4 commits intomasterfrom
bluestreak01 merged 4 commits intomasterfrom
Conversation
puzpuzpuz
added
SQL
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
force-pushed
the
puzpuzpuz_o1_min_max_designated_ts
branch
from
e4a83d5 to
abfcd56
Compare
Member
|
very cool PR @puzpuzpuz ! we also need this optimisation reflected in the query plan and have tests asserting the intended plan to ensure this perf optimisation does not regress |
Contributor
Author
@bluestreak01 good idea. Addressed in 48de7da |
bluestreak01
approved these changes
Jan 4, 2026
Contributor
[PR Coverage check]😍 pass : 45 / 45 (100.00%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of non-keyed GROUP BY queries with
min()/max()functions over the designated timestamp column we can use O(1) operation (take the first/last value) instead of calling SIMD native function: