fix(sql): fix EXPLAIN UPDATE resulting in error#6588
Merged
bluestreak01 merged 1 commit intomasterfrom Jan 2, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluestreak01
changed the title
bluestreak01
changed the title
EXPLAIN UPDATE resulting in error
Contributor
[PR Coverage check]😍 pass : 8 / 8 (100.00%) file detail
|
nwoolmer
approved these changes
Jan 2, 2026
jerrinot
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6194
EXPLAIN UPDATEon WAL tables was throwingUnsupportedOperationExceptionbecause the anonymousRecordCursorFactorycreated during WAL serialization phase did not implementgetCursor().Changes
EmptyTableRecordCursorFactoryto accept an optionalTableTokenfor propersupportsUpdateRowId()checksSqlCodeGenerator.generateTableQuery0()withEmptyTableRecordCursorFactorytoPlan()to show the table name when available (e.g.,on: trades)testExplainUpdateWalTableTest plan
ExplainPlanTest#testExplainUpdateWalTable- reproduces the issue from EXPLAIN is broken for some cases #6194ExplainPlanTesttests pass (515 tests)SqlCodeGeneratorTestandUpdateTestpass