fix(sql): fix false timestamp ordering error with nested SAMPLE BY and ORDER BY#6572
Merged
bluestreak01 merged 1 commit intomasterfrom Dec 22, 2025
Merged
fix(sql): fix false timestamp ordering error with nested SAMPLE BY and ORDER BY#6572bluestreak01 merged 1 commit intomasterfrom
bluestreak01 merged 1 commit intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
[PR Coverage check]😍 pass : 5 / 5 (100.00%) file detail
|
glasstiger
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nested
SAMPLE BYqueries with anORDER BYclause in between incorrectly failed with:Example of failing query:
Root Cause
When
SAMPLE BYneeds ordered timestamp data, it pushestimestampRequired=trueonto a context stack. This flag propagates to nested models and throws an error if ASC timestamp order isn't guaranteed.However, when there's an
ORDER BYclause between the outer and innerSAMPLE BY, the inner model's ordering is irrelevant sinceORDER BYwill re-sort the data anyway.Fix
When an
ORDER BYclause is present, pushtimestampRequired=falseto signal that nested models don't need to maintain timestamp ordering.🤖 Generated with Claude Code