Skip to content

fix(pgwire): add support for SHOW default_transaction_read_only#6562

Merged
bluestreak01 merged 5 commits intomasterfrom
nw_pg_multi_url
Dec 20, 2025
Merged

fix(pgwire): add support for SHOW default_transaction_read_only#6562
bluestreak01 merged 5 commits intomasterfrom
nw_pg_multi_url

Conversation

@nwoolmer
Copy link
Copy Markdown
Contributor

@nwoolmer nwoolmer commented Dec 19, 2025 •
edited
Loading

This metadata query is used by npgsql when building a data source with multiple hosts, and since it was missing, the connection source would fail to initialise. For example:

await using var dataSource = new NpgsqlDataSourceBuilder(
                 $"Host=localhost,127.0.0.1;Port={port};Username=admin;Password=quest;Database=qdb;ServerCompatibilityMode=NoTypeLoading;"
                ).Build();

@nwoolmer nwoolmer added Bug Incorrect or unexpected behavior Postgres Wire Issues or changes relating to Postgres wire protocol Friction labels Dec 19, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nw_pg_multi_url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jerrinot
jerrinot previously approved these changes Dec 19, 2025
View reviewed changes
@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Dec 20, 2025

[PR Coverage check]

😍 pass : 44 / 46 (95.65%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/catalogue/ShowDefaultTransactionReadOnlyCursorFactory.java 10 12 83.33%
🔵 io/questdb/griffin/SqlParser.java 2 2 100.00%
🔵 io/questdb/griffin/SqlOptimiser.java 2 2 100.00%
🔵 io/questdb/griffin/SqlKeywords.java 30 30 100.00%

@bluestreak01 bluestreak01 merged commit fc09e24 into master Dec 20, 2025
43 checks passed
@bluestreak01 bluestreak01 deleted the nw_pg_multi_url branch December 20, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

@jerrinot jerrinot jerrinot left review comments

Assignees

No one assigned

Labels

Bug Incorrect or unexpected behavior Friction Postgres Wire Issues or changes relating to Postgres wire protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nwoolmer @glasstiger @jerrinot @bluestreak01