feat(sql): align glob() function with DuckDB glob syntax#6552
Merged
bluestreak01 merged 11 commits intomasterfrom Dec 22, 2025
Merged
feat(sql): align glob() function with DuckDB glob syntax#6552bluestreak01 merged 11 commits intomasterfrom
glob() function with DuckDB glob syntax#6552bluestreak01 merged 11 commits intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kafka1991
changed the title
glob functionglob() function with DuckDB glob syntax
core/src/main/java/io/questdb/griffin/engine/functions/catalogue/GlobFilesFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/std/str/DirectUtf8StringList.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/catalogue/GlobFilesFunctionFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/catalogue/GlobFilesFunctionFactory.java
Outdated
Show resolved
Hide resolved
...st/java/io/questdb/test/griffin/engine/functions/catalogue/GlobFilesFunctionFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/catalogue/GlobFilesFunctionFactory.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/catalogue/GlobFilesFunctionFactory.java
Show resolved
Hide resolved
…ll safety - Add explicit symlink skip in globFilesInternal for consistency with recursive methods - Fix DirectUtf8StringList.put(DirectUtf8Sequence) to return early for null instead of adding empty element (consistent with put(Utf8Sequence)) - Add javadoc for both put() methods documenting null behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
bluestreak01
approved these changes
Dec 22, 2025
Member
|
build timed out publishing code coverage to http somewhere |
Contributor
[PR Coverage check]😍 pass : 461 / 521 (88.48%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6369
Refactors
glob()function to use native glob matching instead of Java regex, aligning with DuckDB's glob syntax:***?[abc][a-z]