perf(sql): speed up avg() functions in non-keyed GROUP BY queries#6542
Merged
bluestreak01 merged 7 commits intomasterfrom Dec 16, 2025
Merged
perf(sql): speed up avg() functions in non-keyed GROUP BY queries#6542bluestreak01 merged 7 commits intomasterfrom
bluestreak01 merged 7 commits intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluestreak01
previously approved these changes
Dec 16, 2025
Contributor
[PR Coverage check]😍 pass : 15 / 15 (100.00%) file detail
|
bluestreak01
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes redundant division from
avg()function in case of parallel non-keyed GROUP BY, e.g.Native
avg*Acc()functions were usingavg += (v - avg) / cin each iteration while the outerAvg*VectorAggregateFunctionJava function was multiplying the average and the count before storing them in the partial result (sum.add(value * count)).Benchmarks
Test box: Ryzen 7900x, 64GB RAM, Ubuntu 24.04
With ClickBench's
hitstable the difference is: