fix(core): data corruption after range replace on column top partition#6519
Merged
bluestreak01 merged 5 commits intomasterfrom Dec 10, 2025
Merged
fix(core): data corruption after range replace on column top partition#6519bluestreak01 merged 5 commits intomasterfrom
bluestreak01 merged 5 commits intomasterfrom
Conversation
puzpuzpuz
added
Bug
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
[PR Coverage check]😍 pass : 14 / 14 (100.00%) file detail
|
bluestreak01
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug can be reproduced only in case of range replace transactions running on partitions with column tops, so no users are affected. That's because the only place where we use range replace is mat views and it's impossible to add a column to a mat view.
In case of a range replace transaction and a column top,
O3OpenColumnJob#merge*Column()methods could overwrite data in the source partition making it corrupted. As an example, in themergeVarColumn()method theauxRowCountvariable was calculated after we adjustsrcDataMaxandsrcDataTopvalues, soauxRowCountcould end being set to zero while the source partition has some non-coltop rows. Later on, thecolumnTypeDriver.setPartAuxVectorNull()would overwrite the source aux file leaving it with the content like what's shown below.Notice that the second
longvalue in the corruptednew_col_73.ifile no longer holds8, but instead is set to zero. As a result,MatViewFuzzTest#testBaseTableCanHaveColumnsAdded()was flaky: