fix(sql): improve refresh step estimation for sparse data with small sample by interval#6517
Merged
bluestreak01 merged 6 commits intomasterfrom Dec 9, 2025
Merged
fix(sql): improve refresh step estimation for sparse data with small sample by interval#6517bluestreak01 merged 6 commits intomasterfrom
sample by interval#6517bluestreak01 merged 6 commits intomasterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kafka1991
changed the title
sample by interval
kafka1991
changed the title
sample by intervalsample by interval
puzpuzpuz
reviewed
Dec 9, 2025
core/src/main/java/io/questdb/griffin/engine/groupby/MonthTimestampMicrosSampler.java
Outdated
Show resolved
Hide resolved
puzpuzpuz
reviewed
Dec 9, 2025
core/src/main/java/io/questdb/griffin/engine/groupby/MonthTimestampNanosSampler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/groupby/YearTimestampMicrosSampler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/groupby/YearTimestampNanosSampler.java
Outdated
Show resolved
Hide resolved
puzpuzpuz
reviewed
Dec 9, 2025
puzpuzpuz
reviewed
Dec 9, 2025
puzpuzpuz
previously approved these changes
Dec 9, 2025
puzpuzpuz
reviewed
Dec 9, 2025
puzpuzpuz
approved these changes
Dec 9, 2025
Contributor
[PR Coverage check]😍 pass : 26 / 27 (96.30%) file detail
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes inefficient refresh queries when mat views use small sampling intervals (e.g., microsecond) on tables with sparse data distribution. The improved estimation ensures optimal batch sizes for incremental refresh.