Skip to content

fix(sql): fix symbol column nullValue flag when adding column to non-empty table#6507

Merged
bluestreak01 merged 8 commits intomasterfrom
symbol_null_value_fix
Dec 16, 2025
Merged

fix(sql): fix symbol column nullValue flag when adding column to non-empty table#6507
bluestreak01 merged 8 commits intomasterfrom
symbol_null_value_fix

Conversation

@kafka1991
Copy link
Copy Markdown
Collaborator

@kafka1991 kafka1991 commented Dec 5, 2025

When adding a symbol column via ALTER TABLE ADD COLUMN to a table with existing data, the symbol table's nullValue flag should be set to true since all existing rows will have null values for the new column.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch symbol_null_value_fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kafka1991 kafka1991 changed the title fix(sql): fix nullvalue flag in symbolTable for add column fix(sql): fix symbol column nullValue flag when adding column to non-empty table Dec 5, 2025
@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 4 / 4 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableWriter.java 4 4 100.00%

@bluestreak01 bluestreak01 merged commit 3913811 into master Dec 16, 2025
43 checks passed
@bluestreak01 bluestreak01 deleted the symbol_null_value_fix branch December 16, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants