Skip to content

fix(sql): fix potential crash when ORDER BY symbol column added via ALTER TABLE ADD COLUMN#6505

Merged
bluestreak01 merged 3 commits intomasterfrom
orderby_symbol_crash
Dec 7, 2025
Merged

fix(sql): fix potential crash when ORDER BY symbol column added via ALTER TABLE ADD COLUMN#6505
bluestreak01 merged 3 commits intomasterfrom
orderby_symbol_crash

Conversation

@kafka1991
Copy link
Copy Markdown
Collaborator

@kafka1991 kafka1991 commented Dec 5, 2025

This PR fix a crash that occurs when ordering by a symbol column that was added via ALTER TABLE ADD COLUMN.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch orderby_symbol_crash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kafka1991 kafka1991 changed the title fix(sql): ordering by symbol may cause db crash after adding a column fix(sql): fix potential crash when ORDER BY symbol column added via ALTER TABLE ADD COLUMN Dec 5, 2025
@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 6 / 6 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/sql/PageFrameMemoryRecord.java 6 6 100.00%

@bluestreak01 bluestreak01 merged commit c16da79 into master Dec 7, 2025
43 checks passed
@bluestreak01 bluestreak01 deleted the orderby_symbol_crash branch December 7, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants