perf(sql): use unordered maps only in single-column case#6481
Merged
bluestreak01 merged 4 commits intomasterfrom Dec 3, 2025
Merged
perf(sql): use unordered maps only in single-column case#6481bluestreak01 merged 4 commits intomasterfrom
bluestreak01 merged 4 commits intomasterfrom
Conversation
puzpuzpuz
added
SQL
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
force-pushed
the
puzpuzpuz_revisit_maps_mk2
branch
from
ab733ec to
1be4839
Compare
Contributor
[PR Coverage check]😍 pass : 79 / 92 (85.87%) file detail
|
bluestreak01
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny column sinks in
Unordered4MapandUnordered8Mapled to false sharing when jemalloc is in use. So, these maps are now used only in the single column case and support a few 4 byte/8 byte columns.Also, removes
Unordered2Mapsince it shows no improvement on top of other maps, so it's simply not worth it having it in the code base.Benchmarks
This patch significantly reduces execution times of Q15 and Q35 (but not only) in ClickBench when jemalloc is in use. The below results are measured on c6a.metal instance: