fix(core): breaking change 💥 - remove tx scoreboard v1 by jerrinot · Pull Request #6449 · questdb/questdb

jerrinot · 2025-11-25T11:12:43Z

This change removes transaction scoreboard v1.
Deployments explicitly configured with cairo.txn.scoreboard.format=1 will continue to function, but the option will be ignore and the server will use scoreboard v2.

tandem: https://github.com/questdb/questdb-enterprise/pull/798

This change removes transaction scoreboard v1. Deployments explicitly configured with cairo.txn.scoreboard.format=1 will continue to function, but the option will be ignore and the server will use scoreboard v2.

coderabbitai · 2025-11-25T11:12:48Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request removes TxnScoreboardPoolV1 and TxnScoreboardPoolFactory, consolidating transaction scoreboard handling to use only TxnScoreboardPoolV2. Configuration properties and tests that supported multiple scoreboard format versions are eliminated. Checkpoint-based locking guards on partition purge and squash operations are removed, allowing these operations to proceed during checkpoints.

Changes

Cohort / File(s)	Summary
Pool version consolidation `benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java`, `core/src/main/java/io/questdb/cairo/CairoEngine.java`, `core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java`	Replaced TxnScoreboardPoolFactory.createPool() with direct TxnScoreboardPoolV2 instantiation.
Scoreboard format API removal `core/src/main/java/io/questdb/cairo/CairoConfiguration.java`, `core/src/main/java/io/questdb/cairo/CairoConfigurationWrapper.java`, `core/src/main/java/io/questdb/cairo/DefaultCairoConfiguration.java`	Removed getScoreboardFormat() method from interface and implementations.
Configuration deprecation & cleanup `core/src/main/java/io/questdb/PropServerConfiguration.java`	Removed cairoTxnScoreboardFormat field, deprecated CAIRO_TXN_SCOREBOARD_FORMAT property, reorganized HTTP context path SQL field declarations.
Pool factory & V1 implementation removal `core/src/main/java/io/questdb/cairo/TxnScoreboardPoolFactory.java`, `core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV1.java`	Deleted TxnScoreboardPoolFactory class and entire TxnScoreboardPoolV1 implementation.
Checkpoint partition locking removal `core/src/main/java/io/questdb/cairo/DatabaseCheckpointAgent.java`, `core/src/main/java/io/questdb/cairo/DatabaseCheckpointStatus.java`, `core/src/main/java/io/questdb/cairo/ColumnPurgeJob.java`, `core/src/main/java/io/questdb/cairo/O3PartitionPurgeJob.java`, `core/src/main/java/io/questdb/cairo/TableWriter.java`	Removed partitionsLocked() method and checkpoint guards preventing purge/squash operations during checkpoints.
Parameterized test removal `core/src/test/java/io/questdb/test/cairo/TxnScoreboardPoolTest.java`, `core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java`	Removed `@RunWith`(Parameterized.class) annotation, version parameterization, and V1-specific test cases; consolidated to V2-only tests.
Scoreboard property test cleanup `core/src/test/java/io/questdb/test/PropServerConfigurationTest.java`, `core/src/test/java/io/questdb/test/ServerMainTest.java`, `core/src/test/java/io/questdb/test/cairo/TableReaderTest.java`, `core/src/test/java/io/questdb/test/cairo/fuzz/CheckpointFuzzTest.java`, `core/src/test/java/io/questdb/test/cairo/o3/O3PartitionPurgeTest.java`, `core/src/test/java/io/questdb/test/griffin/CheckpointTest.java`	Removed assertions and property configuration related to CAIRO_TXN_SCOREBOARD_FORMAT.
Configuration documentation cleanup `core/src/main/resources/io/questdb/site/conf/server.conf`, `core/src/test/resources/server.conf`, `pkg/ami/marketplace/assets/server.conf`	Removed commented configuration entries and explanatory comments for cairo.txn.scoreboard.format.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas requiring extra attention:
- Checkpoint lock removal logic in TableWriter.java and ColumnPurgeJob.java — verify that removing partition-lock guards does not introduce race conditions during concurrent checkpoint and purge operations.
- DatabaseCheckpointAgent.java — confirm that unconditional scoreboard increment and txn collection are safe and don't duplicate operations.
- Test parameterization removal in TxnScoreboardTest.java and TxnScoreboardPoolTest.java — ensure V2-only coverage is sufficient and no V1-specific bugs are masked.
- HTTP context path reorganization in PropServerConfiguration.java — validate that field declaration relocation preserves initialization order and functional behavior.

Possibly related PRs

feat(http): REST API for SQL validation #6383 — Modifies HTTP SQL validation context-path wiring in PropServerConfiguration and HTTP server endpoint configuration.
feat(sql): add exporting PARQUET functionality to COPY #6008 — Restructures CairoEngine initialization and lifecycle (copyExportContext/copyImportContext, signalClose) alongside transaction scoreboard pool modifications.

Suggested labels

Bug

Suggested reviewers

bluestreak01
ideoma

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.57% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing transaction scoreboard v1 implementation from the codebase.
Description check	✅ Passed	The pull request description clearly describes the changeset: removing transaction scoreboard v1 while maintaining backward compatibility with existing configurations.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

jerrinot · 2025-11-25T11:13:53Z

@coderabbitai please review

coderabbitai · 2025-11-25T11:14:08Z

@jerrinot: I'll review the changes in this PR for you.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (6)

core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java (6)

51-52: Remove unused Parameterized imports.

These imports are no longer needed since the test class was converted from parameterized tests to V2-only tests.

Apply this diff:

-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;

494-500: Simplify by removing dead V1 branch.

Since only TxnScoreboardV2 instances are created in this test, the V1 branch is unreachable dead code.

Apply this diff:

 private static long getActiveReaderCount(TxnScoreboard scoreboard, long txn) {
-    if (scoreboard instanceof TxnScoreboardV2) {
-        return ((TxnScoreboardV2) scoreboard).getActiveReaderCount(txn);
-    } else {
-        return ((TxnScoreboardV1) scoreboard).getActiveReaderCount(txn);
-    }
+    return ((TxnScoreboardV2) scoreboard).getActiveReaderCount(txn);
 }

504-510: Simplify by removing dead V1 branch.

Since only TxnScoreboardV2 instances are created in this test, the V1 branch is unreachable dead code.

Apply this diff:

 private static long getMin(TxnScoreboard scoreboard) {
-    if (scoreboard instanceof TxnScoreboardV2) {
-        return ((TxnScoreboardV2) scoreboard).getMin();
-    } else {
-        return ((TxnScoreboardV1) scoreboard).getMin();
-    }
+    return ((TxnScoreboardV2) scoreboard).getMin();
 }

512-518: Simplify by removing dead V1 branch.

Since only TxnScoreboardV2 instances are created in this test, the V1 branch is unreachable dead code.

Apply this diff:

 private void assertScoreboardMinOrNoLocks(TxnScoreboard scoreboard, long txn) {
-    if (scoreboard instanceof TxnScoreboardV2) {
-        Assert.assertEquals(-1, getMin(scoreboard));
-    } else {
-        Assert.assertEquals(txn, getMin(scoreboard));
-    }
+    Assert.assertEquals(-1, getMin(scoreboard));
 }

619-635: Remove unused version field from Writer class.

The version field is always set to 2 (line 538) and only gates V1-specific logic that is now dead code.

Apply this diff to the Writer constructor and field:

 private static class Writer extends Thread {
 
     private final AtomicInteger anomaly;
     private final CyclicBarrier barrier;
     private final int iterations;
     private final CountDownLatch latch;
     private final TxnScoreboard scoreboard;
-    private final int version;
 
-    private Writer(TxnScoreboard scoreboard, CyclicBarrier barrier, CountDownLatch latch, AtomicInteger anomaly, int iterations, int version) {
+    private Writer(TxnScoreboard scoreboard, CyclicBarrier barrier, CountDownLatch latch, AtomicInteger anomaly, int iterations) {
         this.scoreboard = scoreboard;
         this.barrier = barrier;
         this.latch = latch;
         this.anomaly = anomaly;
         this.iterations = iterations;
-        this.version = version;
     }

637-696: Remove V1-specific dead code from Writer.run().

Lines 647-669 contain V1-specific logic that never executes since version is always 2. This wait logic for slow readers is specific to V1 scoreboard limitations.

Apply this diff to remove the dead code:

         barrier.await();
         for (int i = 0; i < iterations; i++) {
-            if (version == 1) {
-                for (int sleepCount = 0; sleepCount < 50 && txn - getMin(scoreboard) > publishWaitBarrier; sleepCount++) {
-                    // Some readers are slow and haven't released transaction yet. Give them a bit more time
-                    LOG.infoW().$("slow reader release, waiting... [txn=")
-                            .$(txn)
-                            .$(", min=").$(getMin(scoreboard))
-                            .$(", size=").$(scoreboard.getEntryCount())
-                            .I$();
-                    Os.sleep(100);
-                }
-
-                if (txn - getMin(scoreboard) > publishWaitBarrier) {
-                    // Wait didn't help. Abort the test.
-                    anomaly.addAndGet(1000);
-                    LOG.errorW().$("slow reader release, abort [txn=")
-                            .$(txn)
-                            .$(", min=").$(getMin(scoreboard))
-                            .$(", size=").$(scoreboard.getEntryCount())
-                            .I$();
-                    txn = iterations;
-                    return;
-                }
-            }
-
             // This is the only writer

Also update the Writer instantiation at line 538:

-Writer writer = new Writer(scoreboard, barrier, latch, anomaly, iterations, 2);
+Writer writer = new Writer(scoreboard, barrier, latch, anomaly, iterations);

🧹 Nitpick comments (2)

core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java (1)

7575-7583: Directly constructing TxnScoreboardPoolV2 for TableReader is functionally sound

Both helper methods now pass a TxnScoreboardPoolV2 instance into TableReader, which correctly satisfies the TxnScoreboardPool dependency and mirrors the behavior previously obtained via TxnScoreboardPoolFactory.createPool(configuration). This keeps the tests aligned with the new v2‑only scoreboard implementation.

If you ever want to micro‑optimize, you could reuse a single TxnScoreboardPoolV2 per configuration instead of allocating a new one per helper call, but for tests this is purely optional.

Also applies to: 7592-7602

core/src/main/java/io/questdb/PropServerConfiguration.java (1)

231-232: SQL HTTP context path sets aligned with existing pattern

Defining dedicated httpContextPathSqlExecute and httpContextPathSqlValidate sets here matches how other HTTP context paths are handled and keeps the configuration surface consistent. No functional issues spotted. One minor design point: the validation set is only populated with a hard-coded default later in the ctor; if you ever want to make the SQL validation endpoint configurable like the others, you’d likely want a getUrls(...) call for it as well.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25d1059 and 217213c.

📒 Files selected for processing (25)

benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java (2 hunks)
core/src/main/java/io/questdb/PropServerConfiguration.java (3 hunks)
core/src/main/java/io/questdb/cairo/CairoConfiguration.java (0 hunks)
core/src/main/java/io/questdb/cairo/CairoConfigurationWrapper.java (0 hunks)
core/src/main/java/io/questdb/cairo/CairoEngine.java (1 hunks)
core/src/main/java/io/questdb/cairo/ColumnPurgeJob.java (0 hunks)
core/src/main/java/io/questdb/cairo/DatabaseCheckpointAgent.java (1 hunks)
core/src/main/java/io/questdb/cairo/DatabaseCheckpointStatus.java (0 hunks)
core/src/main/java/io/questdb/cairo/DefaultCairoConfiguration.java (0 hunks)
core/src/main/java/io/questdb/cairo/O3PartitionPurgeJob.java (0 hunks)
core/src/main/java/io/questdb/cairo/TableWriter.java (0 hunks)
core/src/main/java/io/questdb/cairo/TxnScoreboardPoolFactory.java (0 hunks)
core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV1.java (0 hunks)
core/src/main/resources/io/questdb/site/conf/server.conf (0 hunks)
core/src/test/java/io/questdb/test/PropServerConfigurationTest.java (0 hunks)
core/src/test/java/io/questdb/test/ServerMainTest.java (0 hunks)
core/src/test/java/io/questdb/test/cairo/TableReaderTest.java (0 hunks)
core/src/test/java/io/questdb/test/cairo/TxnScoreboardPoolTest.java (0 hunks)
core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java (3 hunks)
core/src/test/java/io/questdb/test/cairo/fuzz/CheckpointFuzzTest.java (0 hunks)
core/src/test/java/io/questdb/test/cairo/o3/O3PartitionPurgeTest.java (0 hunks)
core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java (3 hunks)
core/src/test/java/io/questdb/test/griffin/CheckpointTest.java (0 hunks)
core/src/test/resources/server.conf (0 hunks)
pkg/ami/marketplace/assets/server.conf (0 hunks)

💤 Files with no reviewable changes (19)

core/src/test/resources/server.conf
core/src/main/java/io/questdb/cairo/CairoConfiguration.java
core/src/main/java/io/questdb/cairo/O3PartitionPurgeJob.java
core/src/main/java/io/questdb/cairo/DefaultCairoConfiguration.java
core/src/test/java/io/questdb/test/cairo/TableReaderTest.java
core/src/test/java/io/questdb/test/cairo/o3/O3PartitionPurgeTest.java
core/src/test/java/io/questdb/test/ServerMainTest.java
core/src/main/java/io/questdb/cairo/TxnScoreboardPoolFactory.java
core/src/test/java/io/questdb/test/PropServerConfigurationTest.java
core/src/test/java/io/questdb/test/cairo/fuzz/CheckpointFuzzTest.java
core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV1.java
pkg/ami/marketplace/assets/server.conf
core/src/test/java/io/questdb/test/cairo/TxnScoreboardPoolTest.java
core/src/test/java/io/questdb/test/griffin/CheckpointTest.java
core/src/main/java/io/questdb/cairo/DatabaseCheckpointStatus.java
core/src/main/java/io/questdb/cairo/CairoConfigurationWrapper.java
core/src/main/resources/io/questdb/site/conf/server.conf
core/src/main/java/io/questdb/cairo/ColumnPurgeJob.java
core/src/main/java/io/questdb/cairo/TableWriter.java

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-07T00:59:31.522Z

Learnt from: bluestreak01
Repo: questdb/questdb PR: 0
File: :0-0
Timestamp: 2025-11-07T00:59:31.522Z
Learning: In QuestDB's Cairo engine, transaction (_txn) files have a strong invariant: they are never truncated below TX_BASE_HEADER_SIZE. Once created, they are either fully formed (size >= header size) or completely removed along with the entire table directory when the table is dropped.

Applied to files:

core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java

🧬 Code graph analysis (4)

core/src/main/java/io/questdb/cairo/DatabaseCheckpointAgent.java (2)

core/src/main/c/share/txn_board.cpp (8)

txn (55-79)

txn (55-55)

txn (104-114)

txn (104-104)

txn (117-161)

txn (117-117)

txn (164-170)

txn (164-164)

core/src/main/java/io/questdb/std/Numbers.java (1)

Numbers (44-3523)

benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java (1)

core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV2.java (1)

TxnScoreboardPoolV2 (36-131)

core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java (1)

core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV2.java (1)

TxnScoreboardPoolV2 (36-131)

core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java (1)

core/src/main/java/io/questdb/cairo/TxnScoreboardPoolV2.java (1)

TxnScoreboardPoolV2 (36-131)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (35)

GitHub Check: New pull request (SelfHosted Running tests with cover on linux-other)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-pgwire)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-cairo-sub)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-cairo-root)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-fuzz2)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-fuzz1)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-griffin-sub)
GitHub Check: New pull request (SelfHosted Other tests on linux-x86-graal)
GitHub Check: New pull request (SelfHosted Running tests with cover on linux-griffin-root)
GitHub Check: New pull request (SelfHosted Cairo tests on linux-x86-graal)
GitHub Check: New pull request (Rust Test and Lint on linux-jdk17)
GitHub Check: New pull request (SelfHosted Other tests on linux-x64-zfs)
GitHub Check: New pull request (Hosted Running tests on windows-other-2)
GitHub Check: New pull request (Hosted Running tests on windows-other-1)
GitHub Check: New pull request (Hosted Running tests on windows-pgwire)
GitHub Check: New pull request (Hosted Running tests on windows-cairo-2)
GitHub Check: New pull request (Hosted Running tests on windows-cairo-1)
GitHub Check: New pull request (Hosted Running tests on windows-fuzz2)
GitHub Check: New pull request (Hosted Running tests on windows-fuzz1)
GitHub Check: New pull request (Hosted Running tests on windows-griffin-sub)
GitHub Check: New pull request (Hosted Running tests on windows-griffin-base)
GitHub Check: New pull request (Hosted Running tests on mac-other)
GitHub Check: New pull request (Hosted Running tests on mac-pgwire)
GitHub Check: New pull request (Hosted Running tests on mac-cairo-fuzz)
GitHub Check: New pull request (SelfHosted Other tests on linux-arm64)
GitHub Check: New pull request (Hosted Running tests on mac-cairo)
GitHub Check: New pull request (Hosted Running tests on mac-griffin)
GitHub Check: New pull request (SelfHosted Cairo tests on linux-arm64)
GitHub Check: New pull request (SelfHosted Griffin tests on linux-arm64)
GitHub Check: New pull request (SelfHosted Cairo tests on linux-x64-zfs)
GitHub Check: New pull request (SelfHosted Griffin tests on linux-x64-zfs)
GitHub Check: New pull request (SelfHosted Griffin tests on linux-x86-graal)
GitHub Check: New pull request (Check Changes Check changes)
GitHub Check: build
GitHub Check: build

🔇 Additional comments (7)

core/src/main/java/io/questdb/cairo/CairoEngine.java (1)

196-196: LGTM - Clean migration to V2 complete.

The direct instantiation of TxnScoreboardPoolV2 is correct and aligns with the PR objective to remove scoreboard V1. Verification confirms:

Factory and V1 classes completely removed

Configuration property properly registered as deprecated (silently ignored, not erroring)

No production code reads the deprecated format value

Tests appropriately parameterized for compatibility testing

EmptyTxnScoreboardPool is a separate stub implementation for COPY SQL operations (unrelated to V1/V2 migration)

core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java (1)

75-75: LGTM - Correctly migrated to V2.

The direct instantiation of TxnScoreboardPoolV2 correctly implements the V1 removal objective.

core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java (1)

43-43: TxnScoreboardPoolV2 import is correct and consistent with the PR direction

The new import matches the updated usages below and aligns with removing the v1/factory path. No issues here.

benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java (1)

36-36: LGTM! Import correctly updated to V2.

The import change from TxnScoreboardPoolFactory to TxnScoreboardPoolV2 aligns with the PR objective to consolidate transaction scoreboard handling to use only V2.

core/src/main/java/io/questdb/PropServerConfiguration.java (2)

2638-2685: Deprecation of cairo.txn.scoreboard.format correctly preserves compatibility

Registering PropertyKey.CAIRO_TXN_SCOREBOARD_FORMAT as deprecated (with no replacements) causes it to be recognized and reported as “No longer used” without being treated as obsolete or invalid. Given validateProperties() only throws when isError is true (i.e., for incorrect/obsolete keys), this ensures:

Existing configs using cairo.txn.scoreboard.format continue to start even with CONFIG_VALIDATION_STRICT=true.

Operators still get an advisory log telling them the setting is no longer used.

This matches the PR intent to ignore the v1/v2 switch while remaining backward compatible.

4688-4691: New getContextPathSqlValidation() override cleanly exposes validation endpoints

Wiring getContextPathSqlValidation() to httpContextPathSqlValidate brings the SQL-validation paths in line with the other HTTP context path accessors and makes the contract explicit on HttpFullFatServerConfiguration. Implementation is straightforward and consistent with the surrounding getters.

core/src/main/java/io/questdb/cairo/DatabaseCheckpointAgent.java (1)

316-328: LGTM! Scoreboard locking now unconditionally applied.

The removal of the conditional check ensures that checkpoint operations always use scoreboard v2 transaction locking, which aligns with the PR objective. The logic correctly:

Acquires a txn lock via scoreboard.incrementTxn()

Stores the txn and associated metadata for later release

Uses proper encoding (Numbers.encodeLowHighInts) that matches the decoding in releaseScoreboardTxns()

The error handling at line 318-320 ensures that if the scoreboard lock cannot be acquired, the checkpoint fails gracefully and resources are cleaned up via the catch block at line 378.

benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java

core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java

core/src/test/java/io/questdb/test/cairo/o3/O3PartitionPurgeTest.java

core/src/test/java/io/questdb/test/cairo/fuzz/CheckpointFuzzTest.java

bluestreak01 · 2025-11-25T21:56:27Z

@jerrinot please submit Ent tandem PR and link in the description

…moved

jerrinot · 2025-11-27T13:14:57Z

@bluestreak01 done: https://github.com/questdb/questdb-enterprise/pull/798

…moved

bluestreak01 · 2025-11-27T15:38:57Z

@jerrinot we can probably remove TxnScoreboard and rename TxnScoreboardV2 -> TxnScoreboard. Having V2 solo is going to be confusing.

jerrinot · 2025-11-27T16:53:03Z

@bluestreak01 there is a dummy impl use in SQL COPY:

questdb/core/src/main/java/io/questdb/cairo/EmptyTxnScoreboardPool.java

Line 31 in 7645480

    
           public static final EmptyTxnScoreboardPool INSTANCE = new EmptyTxnScoreboardPool();

bluestreak01 · 2025-11-27T16:59:38Z

it is subclassing a class i think, not the interface

bluestreak01 · 2025-11-27T17:14:37Z

@jerrinot you're right, copy is using it

glasstiger · 2025-11-27T18:39:53Z

[PR Coverage check]

😍 pass : 14 / 15 (93.33%)

file detail

	path	covered line	new line	coverage
🔵	io/questdb/cairo/DatabaseCheckpointAgent.java	9	10	90.00%
🔵	io/questdb/PropServerConfiguration.java	4	4	100.00%
🔵	io/questdb/cairo/CairoEngine.java	1	1	100.00%

fix(core): breaking change 💥 - remove tx scoreboard v1

217213c

This change removes transaction scoreboard v1. Deployments explicitly configured with cairo.txn.scoreboard.format=1 will continue to function, but the option will be ignore and the server will use scoreboard v2.

jerrinot added the Core Related to storage, data type, etc. label Nov 25, 2025

coderabbitai bot reviewed Nov 25, 2025

View reviewed changes

benchmarks/src/main/java/org/questdb/TableReaderReloadBenchmark.java Show resolved Hide resolved

core/src/test/java/io/questdb/test/cairo/TxnScoreboardTest.java Outdated Show resolved Hide resolved

ideoma reviewed Nov 25, 2025

View reviewed changes

core/src/test/java/io/questdb/test/cairo/o3/O3PartitionPurgeTest.java Show resolved Hide resolved

core/src/test/java/io/questdb/test/cairo/fuzz/CheckpointFuzzTest.java Show resolved Hide resolved

remove test parametrization

3faa593

jerrinot and others added 3 commits November 27, 2025 13:44

Merge remote-tracking branch 'origin/master' into jh_scoreboard_v1_re…

c2a0721

…moved

remove actual impl

6bb8ee3

Rebuild CXX libraries

9078464

Merge remote-tracking branch 'origin/master' into jh_scoreboard_v1_re…

9037494

…moved

cleanup

f743461

Merge branch 'master' into jh_scoreboard_v1_removed

45f866e

bluestreak01 approved these changes Nov 27, 2025

View reviewed changes

bluestreak01 merged commit baa5564 into master Nov 27, 2025
45 checks passed

bluestreak01 deleted the jh_scoreboard_v1_removed branch November 27, 2025 19:12

coderabbitai bot mentioned this pull request Jan 15, 2026

chore(core): adds groundwork for incremental backup + removes undocumented table backup #6647

Merged

Conversation

jerrinot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

jerrinot commented Nov 25, 2025

Uh oh!

coderabbitai bot commented Nov 25, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bluestreak01 commented Nov 25, 2025

Uh oh!

jerrinot commented Nov 27, 2025

Uh oh!

bluestreak01 commented Nov 27, 2025

Uh oh!

jerrinot commented Nov 27, 2025

Uh oh!

bluestreak01 commented Nov 27, 2025

Uh oh!

bluestreak01 commented Nov 27, 2025

Uh oh!

glasstiger commented Nov 27, 2025

[PR Coverage check]

file detail

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerrinot commented Nov 25, 2025 •

edited

Loading

coderabbitai bot commented Nov 25, 2025 •

edited

Loading