Skip to content

fix(core): fix rare suspended WAL table when ALTER and RENAME are executed concurrently#6440

Merged
bluestreak01 merged 2 commits intomasterfrom
fix-table-ref-exception-wal-apply
Nov 24, 2025
Merged

fix(core): fix rare suspended WAL table when ALTER and RENAME are executed concurrently#6440
bluestreak01 merged 2 commits intomasterfrom
fix-table-ref-exception-wal-apply

Conversation

@ideoma
Copy link
Copy Markdown
Collaborator

@ideoma ideoma commented Nov 24, 2025

This PR handles TableReferenceOutOfDateException when ALTER TABLE is re-compiled inside WAL apply process.

Also this PR ports some minor fixes from #6416

  • Removes error logging about lock errors of wa*.lock files; these are now logged as a debug category
  • Fixes wrong writerTxn in wal_tables query, sometimes sporadically observed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-table-ref-exception-wal-apply

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 11 / 15 (73.33%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/wal/ApplyWal2TableJob.java 0 1 00.00%
🔵 io/questdb/cairo/TableUtils.java 9 12 75.00%
🔵 io/questdb/cairo/wal/WalPurgeJob.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/catalogue/WalTableListFunctionFactory.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit 7346b11 into master Nov 24, 2025
42 checks passed
@bluestreak01 bluestreak01 deleted the fix-table-ref-exception-wal-apply branch November 24, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants