fix(sql): cannot compile query with aggregate function containing unary minus#6404
Merged
bluestreak01 merged 3 commits intomasterfrom Nov 20, 2025
Merged
fix(sql): cannot compile query with aggregate function containing unary minus#6404bluestreak01 merged 3 commits intomasterfrom
bluestreak01 merged 3 commits intomasterfrom
Conversation
…er aggregate rewrite
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…then this is an extra safety check.
nwoolmer
added
Bug
Contributor
[PR Coverage check]😍 pass : 1 / 1 (100.00%) file detail
|
ideoma
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6403
The optimiser code assumed binary
-/+. In the unary case, it did not nullcheck. Also added a check to ensure it is a binary op.