Skip to content

fix(ilp): remove multi-url blacklisting code#6393

Merged
bluestreak01 merged 2 commits intomasterfrom
nw_blacklist
Nov 15, 2025
Merged

fix(ilp): remove multi-url blacklisting code#6393
bluestreak01 merged 2 commits intomasterfrom
nw_blacklist

Conversation

@nwoolmer
Copy link
Copy Markdown
Contributor

@nwoolmer nwoolmer commented Nov 13, 2025

Closes #6330

@nwoolmer nwoolmer added Bug Incorrect or unexpected behavior ILP Issues or changes relating to Influx Line Protocol labels Nov 13, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Removes host blacklist tracking and retry control optimization from the line sender. The retry loop now iterates across all hosts without checking prior blacklist state, allowing recovery in dynamic deployment scenarios where host roles change mid-retry.

Changes

Cohort / File(s) Summary
Host Blacklist Logic Removal
core/src/main/java/io/questdb/cutlass/line/http/AbstractLineHttpSender.java
Removed hostBlacklistBitmap, blacklistableCount, and allBlacklistedMask declarations. Deleted conditional blocks that skipped blacklisted hosts during iteration and logic that marked hosts as blacklisted on non-retryable HTTP responses. Retry loop now continues over all hosts based on retry deadlines rather than blacklist state.

Sequence Diagram(s)

sequenceDiagram
    participant Sender
    participant Host A
    participant Host B

    Note over Sender: Before: With Blacklisting
    Sender->>Host A: Send request (fails - non-retryable)
    Note over Sender: Blacklist Host A
    Sender->>Host B: Try Host B
    Host B->>Sender: Reject (read-only)
    Note over Sender: Blacklist Host B<br/>(no hosts available)
    Note over Sender: Wait for retry deadline...<br/>(artificial delay)

    Note over Sender: After: Without Blacklisting
    Sender->>Host A: Send request (fails)
    Sender->>Host B: Try Host B
    Host B->>Sender: Reject (read-only)
    Sender->>Host A: Immediately retry Host A<br/>(no blacklist state)
    Note over Sender: Continues retrying based<br/>on deadline, not blacklist
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify all references to blacklist bitmap and related fields are removed
  • Confirm retry loop logic remains intact and functions correctly without blacklist state checks
  • Validate that no other code paths depend on the removed blacklist tracking mechanism

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(ilp): remove multi-url blacklisting code' directly and clearly describes the main change in the PR, which is the removal of blacklist tracking and retry control logic from the line sender.
Description check ✅ Passed The description references issue #6330, which is directly related to the changeset's objective of removing blacklisting from Java ILP /settings check.
Linked Issues check ✅ Passed The PR successfully removes blacklisting logic from AbstractLineHttpSender, which directly addresses issue #6330's requirement to eliminate blacklist tracking that causes failover delays.
Out of Scope Changes check ✅ Passed All changes are scoped to removing blacklist-related code from AbstractLineHttpSender, which is directly aligned with the linked issue's objective; no out-of-scope modifications are apparent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bluestreak01
Copy link
Copy Markdown
Member

@CodeRabbit review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 15, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 0 / 0 (0%)

@bluestreak01 bluestreak01 merged commit db3d65f into master Nov 15, 2025
41 checks passed
@bluestreak01 bluestreak01 deleted the nw_blacklist branch November 15, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Incorrect or unexpected behavior ILP Issues or changes relating to Influx Line Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove blacklisting from Java ILP /settings check

3 participants