fix(sql): always free parquet buffers when executing queries in parallel#6372
Merged
bluestreak01 merged 7 commits intomasterfrom Nov 12, 2025
Merged
fix(sql): always free parquet buffers when executing queries in parallel#6372bluestreak01 merged 7 commits intomasterfrom
bluestreak01 merged 7 commits intomasterfrom
Conversation
puzpuzpuz
added
Bug
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
changed the title
nwoolmer
previously approved these changes
Nov 11, 2025
Contributor
nwoolmer
left a comment
nwoolmer
left a comment
There was a problem hiding this comment.
Looks good to me, will get heavier testing as part of read_parquet upgrades
Contributor
|
(after failed tests are fixed!) |
Contributor
[PR Coverage check]😍 pass : 117 / 118 (99.15%) file detail
|
Contributor
Author
|
@nwoolmer it's all green now. |
nwoolmer
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, queries like the below one lead to OOM:
Here,
hits.parquetis ClickBench test file and it has large row groups (up to 600K rows). Combined with lack of projections (#5280), this easily leads to OOM errors since we were keeping row group buffers around for each page frame reduce task.