Skip to content

feat(sql): add first_not_null(array) #6344

Merged
bluestreak01 merged 12 commits intoquestdb:masterfrom
mcadariu:first_non_null_array
Nov 20, 2025
Merged

feat(sql): add first_not_null(array) #6344
bluestreak01 merged 12 commits intoquestdb:masterfrom
mcadariu:first_non_null_array

Conversation

@mcadariu
Copy link
Copy Markdown
Contributor

@mcadariu mcadariu commented Nov 3, 2025

This PR relates to #4120.

The implementation is inspired by FirstNotNullStrGroupByFunction. The difference is that the boolean column type is present only in FirstNonNullArrayGroupByFunction and not in the superclass, like in the FirstStrGroupByFunction hierarchy. This way the boolean column is present only where strictly needed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mcadariu mcadariu changed the title feat(sql): Implement first_non_null(array) using array sink feat(sql): implement first_non_null(array) using array sink Nov 4, 2025
@mcadariu mcadariu changed the title feat(sql): implement first_non_null(array) using array sink feat(sql): add first_non_null(array) using array sink Nov 4, 2025
@mcadariu mcadariu changed the title feat(sql): add first_non_null(array) using array sink feat(sql): add first_non_null(array) Nov 5, 2025
Copy link
Copy Markdown
Contributor

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict in the parallel group by test. Could you resolve it?

@mcadariu mcadariu force-pushed the first_non_null_array branch from 52da998 to 313be79 Compare November 10, 2025 09:37
@mcadariu mcadariu changed the title feat(sql): add first_non_null(array) feat(sql): add first_not_null(array) Nov 10, 2025
@mcadariu
Copy link
Copy Markdown
Contributor Author

Thanks for your feedback!

@puzpuzpuz
Copy link
Copy Markdown
Contributor

Thanks for another solid contribution!

@puzpuzpuz puzpuzpuz added Enhancement Enhance existing functionality SQL Issues or changes relating to SQL execution labels Nov 11, 2025
@bluestreak01 bluestreak01 merged commit 4ff2877 into questdb:master Nov 20, 2025
30 checks passed
@mcadariu
Copy link
Copy Markdown
Contributor Author

Thanks @bluestreak01!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Enhance existing functionality SQL Issues or changes relating to SQL execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants