feat(sql): add first_not_null(array) #6344
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
left a comment
There was a problem hiding this comment.
There is a merge conflict in the parallel group by test. Could you resolve it?
...ava/io/questdb/griffin/engine/functions/groupby/FirstNonNullArrayGroupByFunctionFactory.java
Outdated
Show resolved
Hide resolved
...estdb/test/griffin/engine/functions/groupby/FirstNonNullArrayGroupByFunctionFactoryTest.java
Outdated
Show resolved
Hide resolved
.../main/java/io/questdb/griffin/engine/functions/groupby/FirstNonNullArrayGroupByFunction.java
Outdated
Show resolved
Hide resolved
… first_non_null column
52da998 to
313be79
Compare
|
Thanks for your feedback! |
|
Thanks for another solid contribution! |
|
Thanks @bluestreak01! |
This PR relates to #4120.
The implementation is inspired by
FirstNotNullStrGroupByFunction. The difference is that the boolean column type is present only inFirstNonNullArrayGroupByFunctionand not in the superclass, like in theFirstStrGroupByFunctionhierarchy. This way the boolean column is present only where strictly needed.