Skip to content

chore(build): update JDK used in container images#6341

Merged
bluestreak01 merged 5 commits intomasterfrom
jh_latest_jdk
Nov 7, 2025
Merged

chore(build): update JDK used in container images#6341
bluestreak01 merged 5 commits intomasterfrom
jh_latest_jdk

Conversation

@jerrinot
Copy link
Copy Markdown
Contributor

@jerrinot jerrinot commented Nov 3, 2025

No description provided.

@jerrinot
Copy link
Copy Markdown
Contributor Author

jerrinot commented Nov 3, 2025

@coderabbitai review please

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 3, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Modified core/Dockerfile to introduce a parameterizable JDK version. Added ARG JDK_VERSION to optionally override the default Java 17 Amazon Corretto installation with a specific version via conditional logic during image build.

Changes

Cohort / File(s) Summary
Docker build configuration
core/Dockerfile		 Introduced ARG JDK_VERSION parameter. Refactored JDK installation from unconditional to conditional: default java-17-amazon-corretto-jdk when parameter is empty, or versioned package (1:${JDK_VERSION}) when specified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Review the conditional logic syntax (RUN if/then structure in Dockerfile)
  • Verify backward compatibility when JDK_VERSION is not provided
  • Confirm version string formatting (1:${JDK_VERSION}) aligns with package repository expectations

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description is completely absent—no description was provided by the author. According to the lenient evaluation criteria for this check, a description should ideally relate to the changeset in some way. Since there is no description content to evaluate, this makes it impossible to determine whether it is related or unrelated to the changeset. To improve clarity and provide context for reviewers, please add a pull request description that explains the motivation behind the changes, how the new JDK_VERSION argument works, and any testing performed to validate the conditional installation logic.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'chore(build): update JDK used in container images' is clearly related to the main change in the changeset. The raw summary confirms that the core change involves introducing a new ARG JDK_VERSION parameter and conditionally installing JDK versions in the Dockerfile, which directly aligns with updating the JDK used in container images. The title is concise, specific, and accurately summarizes the primary modification.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 3, 2025

@jerrinot: I'll review the changes for you.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jerrinot jerrinot changed the title chore(build): container images uses latest JDK by default chore(build): update JDK used in container images Nov 3, 2025
@bluestreak01 bluestreak01 merged commit 976b8d6 into master Nov 7, 2025
5 of 7 checks passed
@bluestreak01 bluestreak01 deleted the jh_latest_jdk branch November 7, 2025 17:19
@coderabbitai coderabbitai bot mentioned this pull request Nov 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerrinot @bluestreak01