core/src/main/java/io/questdb/griffin/SqlCodeGenerator.java (1)

5913-5924: Minor: cache column metadata to avoid repeated lookups.

Optional micro‑refactor: store metadata.getColumnMetadata(columnIndex) once and reuse for flags/capacity reads.

-                    queryMeta.add(new TableColumnMetadata(
-                            Chars.toString(column.getName()),
-                            type,
-                            metadata.isColumnIndexed(columnIndex),
-                            metadata.getIndexValueBlockCapacity(columnIndex),
-                            metadata.isSymbolTableStatic(columnIndex),
-                            metadata.getMetadata(columnIndex),
-                            -1,
-                            false,
-                            0,
-                            metadata.getColumnMetadata(columnIndex).isSymbolCacheFlag(),
-                            metadata.getColumnMetadata(columnIndex).getSymbolCapacity()
-                    ));
+                    final TableColumnMetadata baseMeta = metadata.getColumnMetadata(columnIndex);
+                    queryMeta.add(new TableColumnMetadata(
+                            Chars.toString(column.getName()),
+                            type,
+                            baseMeta.isSymbolIndexFlag(),
+                            baseMeta.getIndexValueBlockCapacity(),
+                            baseMeta.isSymbolTableStatic(),
+                            metadata.getMetadata(columnIndex),
+                            -1,
+                            false,
+                            0,
+                            baseMeta.isSymbolCacheFlag(),
+                            baseMeta.getSymbolCapacity()
+                    ));

core/src/test/java/io/questdb/test/griffin/SqlCodeGeneratorTest.java (1)

2514-2526: Solid regression test; tiny nits for robustness and naming

• Approves: the test cleanly reproduces the join+agg invalid-column case and verifies the improved error message under leak checking. Good coverage.

• Optional: the hard-coded position 136 can be fragile if the SQL is reformatted. Consider computing it from the token location to keep the test stable:

-            assertExceptionNoLeakCheck(
-                    "SELECT o.*, avg(p.bid) avg_big, avg(p.ask) avg_ask FROM orders o LEFT OUTER JOIN prices p ON p.sym = o.sym and p.ts >= dateadd('s', -1, o.ts) and p.ts <= dateadd('s', 1, o.ts);",
-                    136,
-                    "Invalid column: ts",
-                    sqlExecutionContext
-            );
+            final String sql =
+                    "SELECT o.*, avg(p.bid) avg_big, avg(p.ask) avg_ask FROM orders o LEFT OUTER JOIN prices p " +
+                    "ON p.sym = o.sym and p.ts >= dateadd('s', -1, o.ts) and p.ts <= dateadd('s', 1, o.ts);";
+            final int pos = sql.indexOf("o.ts") + "o.".length(); // point at 'ts'
+            assertExceptionNoLeakCheck(sql, pos, "Invalid column: ts", sqlExecutionContext);

• Optional: rename to testJoinUsesNonexistentColumn for clarity.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro